feat add mycelium reconnect logic #22

					
				@ -4,1 +4,3 @@

				pub fn execute(manager: &mut VmManager, args: &InspectArgs) -> anyhow::Result<()> {

				pub async fn execute(manager: &mut VmManager, args: &InspectArgs) -> anyhow::Result<()> {

				    // Run mycelium health check for running VMs before displaying state.

				    if let Err(e) = manager.check_mycelium_health(&args.container).await {

-- open for discussion

can't we make the health checking an option? --check-health
to avoid having to wait for 10s before seeing any output even if the user's goal of the inspect command wasn't to test mycelium?

-- open for discussion can't we make the health checking an option? `--check-health` to avoid having to wait for 10s before seeing any output even if the user's goal of the inspect command wasn't to test mycelium?

👍 1

salmaelsoly marked this conversation as resolved

crates/chvm-lib/src/vm/manager.rs Outdated

					
				@ -533,0 +569,4 @@

				            .and_then(|ns| ns.mycelium_ip.as_deref())

				            .filter(|ip| !ip.is_empty());

				        let health = match (&probed_ip, known_ip) {

the match can be simplified to

 let health = if probed_ip.is_some() {
            MyceliumHealth::Healthy
        } else {
            tokio::time::timeout(
                health_timeout,
                self.check_mycelium_process(&vsock_path, &state.id),
            )
            .await
            .unwrap_or(MyceliumHealth::Unknown)
        };

as last two cases do the exact same thing, can also collapse them into single (None, _)

the match can be simplified to ``` let health = if probed_ip.is_some() { MyceliumHealth::Healthy } else { tokio::time::timeout( health_timeout, self.check_mycelium_process(&vsock_path, &state.id), ) .await .unwrap_or(MyceliumHealth::Unknown) }; ``` as last two cases do the exact same thing, can also collapse them into single (None, _)

salmaelsoly marked this conversation as resolved

salmaelsoly added 1 commit

2026-03-08 09:23:20 +00:00

refactor: inspect command

Unit and Integration Test / test (push) Successful in 1m49s

Details

de932b4966

salmaelsoly requested review from rawan

2026-03-08 13:22:50 +00:00

rawan approved these changes

2026-03-08 21:30:18 +00:00

Dismissed

salmaelsoly added 1 commit

2026-03-09 10:17:18 +00:00

refactor: enhance zombie reaping logic to include main process exit handling

Unit and Integration Test / test (push) Successful in 1m52s

Details

f3ed521003

salmaelsoly requested review from rawan

2026-03-09 10:18:56 +00:00

salmaelsoly changed title from ~~feat add mycelium reconnect logic~~ to WIP: feat add mycelium reconnect logic

2026-03-10 11:46:59 +00:00

salmaelsoly changed title from ~~WIP: feat add mycelium reconnect logic~~ to feat add mycelium reconnect logic

2026-03-10 12:46:06 +00:00

rawan requested changes

2026-03-10 22:42:49 +00:00

Dismissed

crates/chvm-init/src/signal.rs Outdated

					
				@ -22,0 +74,4 @@

				            } else if mycelium_pid == Some(raw_pid) {

				                eprintln!("[init] Mycelium (PID {raw_pid}) exited, scheduling restart...");

				                if let Some(mut child) = mycelium_child.take() {

				                    let _ = child.wait();

now this child.wait() internally calls waitpid again for the same PID that was already reaped above, so the kernel returns ECHILD ("no such child").
so we're now doing something that always fails

fix: remove the .wait() call since it serves no purpose. The .take() already removes the Child from the Option, and dropping it is enough to clean up the Rust-side resources

now this `child.wait()` internally calls waitpid again for the same PID that was already reaped above, so the kernel returns `ECHILD` ("no such child"). so we're now doing something that always fails fix: remove the .wait() call since it serves no purpose. The .take() already removes the Child from the Option, and dropping it is enough to clean up the Rust-side resources

salmaelsoly marked this conversation as resolved

salmaelsoly added 1 commit

2026-03-11 09:06:15 +00:00

refactor: simplify mycelium restart handling by removing unnecessary child wait

Unit and Integration Test / test (push) Successful in 1m50s

Details

6c4acd1d9b

salmaelsoly requested review from rawan

2026-03-11 11:07:46 +00:00

rawan approved these changes

2026-03-12 00:20:47 +00:00

salmaelsoly merged commit 613d335ea6 into development