geomind_code/webgateway
22
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

feat: enhance OpenRPC specification with method metadata and structured responses #30

Merged
salmaelsoly merged 4 commits from development_jsonrpc_spec into main 2026-03-04 10:57:23 +00:00
Conversation 3 Commits 4 Files changed 5 +419 -612
salmaelsoly commented 2026-02-26 12:41:30 +00:00
Member
Copy link

#11

#11
feat: enhance OpenRPC specification with method metadata and structured responses
Some checks failed
Test / test (push) Successful in 1m33s
Details
Build / build (push) Successful in 10m29s
Details
Lint / lint (push) Failing after 5m57s
Details
728c81a429
refactor: update error handling in OpenRPC spec generation
Some checks failed
Lint / lint (push) Failing after 1m15s
Details
Build / build (push) Has been cancelled
Details
Test / test (push) Has been cancelled
Details
78cad9059b
salmaelsoly force-pushed development_jsonrpc_spec from 78cad9059b
Some checks failed
Lint / lint (push) Failing after 1m15s
Details
Build / build (push) Has been cancelled
Details
Test / test (push) Has been cancelled
Details
to 8d1e70c8de
All checks were successful
Build / build (push) Successful in 2m4s
Details
Test / test (push) Successful in 2m8s
Details
Lint / lint (push) Successful in 10m48s
Details
2026-03-01 08:11:16 +00:00 Compare
salmaelsoly changed title from WIP: feat: enhance OpenRPC specification with method metadata and structured responses to feat: enhance OpenRPC specification with method metadata and structured responses 2026-03-01 08:21:53 +00:00
eslamnawara reviewed 2026-03-03 12:08:31 +00:00
caddy/openrpc/router.go Outdated
@ -47,0 +62,4 @@
Result: HealthResult{},
})
r.Register("rpc.discover", r.handleRPCDiscover, MethodMeta{
Description: "Get the OpenRPC specification for this API",
eslamnawara commented 2026-03-03 12:03:17 +00:00
Member
Copy link

can we add the expected results here?

can we add the expected results here?
salmaelsoly marked this conversation as resolved
caddy/openrpc/router.go Outdated
@ -54,0 +78,4 @@
r.Register("services.list", r.handleMyceliumServicesList, MethodMeta{
Description: "List all services for the authenticated user",
Result: config.MyceliumService{},
ResultArray: true,
eslamnawara commented 2026-03-03 12:00:53 +00:00
Member
Copy link

Please add the possible error responses here, this might return Authentication failure error and internal error

Please add the possible error responses here, this might return Authentication failure error and internal error
eslamnawara commented 2026-03-03 12:01:27 +00:00
Member
Copy link

apply for all methods

apply for all methods
salmaelsoly marked this conversation as resolved
refactor: add all expected errors in method registering
All checks were successful
Test / test (push) Successful in 10m20s
Details
Build / build (push) Successful in 10m51s
Details
Lint / lint (push) Successful in 11m15s
Details
5ec33c1585
eslamnawara commented 2026-03-04 02:39:26 +00:00
Member
Copy link

lgtm, but can you try rebase and generate specs for admin interface too? it was added recently and I don't see them in your implementation

lgtm, but can you try rebase and generate specs for admin interface too? it was added recently and I don't see them in your implementation
👍 1
salmaelsoly force-pushed development_jsonrpc_spec from 5ec33c1585
All checks were successful
Test / test (push) Successful in 10m20s
Details
Build / build (push) Successful in 10m51s
Details
Lint / lint (push) Successful in 11m15s
Details
to 3a7aadd975
Some checks failed
Lint / lint (push) Failing after 0s
Details
Test / test (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
2026-03-04 08:38:19 +00:00 Compare
salmaelsoly changed target branch from development to main 2026-03-04 08:39:14 +00:00
salmaelsoly force-pushed development_jsonrpc_spec from 3a7aadd975
Some checks failed
Lint / lint (push) Failing after 0s
Details
Test / test (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
to 1f57a7936f
Some checks failed
Lint / lint (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
Test / test (push) Has been cancelled
Details
2026-03-04 08:42:37 +00:00 Compare
salmaelsoly force-pushed development_jsonrpc_spec from 1f57a7936f
Some checks failed
Lint / lint (push) Has been cancelled
Details
Build / build (push) Has been cancelled
Details
Test / test (push) Has been cancelled
Details
to 99c6d14a18
All checks were successful
Test / test (push) Successful in 10m40s
Details
Lint / lint (push) Successful in 10m57s
Details
Build / build (push) Successful in 10m17s
Details
2026-03-04 08:47:11 +00:00 Compare
salmaelsoly force-pushed development_jsonrpc_spec from 99c6d14a18
All checks were successful
Test / test (push) Successful in 10m40s
Details
Lint / lint (push) Successful in 10m57s
Details
Build / build (push) Successful in 10m17s
Details
to 965ceb7562
All checks were successful
Lint / lint (push) Successful in 10m45s
Details
Test / test (push) Successful in 11m5s
Details
Build / build (push) Successful in 10m14s
Details
2026-03-04 10:46:26 +00:00 Compare
Sign in to join this conversation.
Reviewers
No reviewers
eslamnawara
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
geomind_code/webgateway!30
No description provided.