geomind_research/hero_ledger
19
0
Fork 1
Code Issues 9 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Rhai improvements #19

New issue
Open
opened 2026-01-08 02:03:44 +00:00 by scott · 0 comments
scott commented 2026-01-08 02:03:44 +00:00
Member
Copy link

There is some room for improvement in the Rhai engine:

  • Boilerplate code to call async (since Rhai can't do this natively)
    • Done via async wrappers, need to test more
  • Use of generic call_function where there should be an SDK function implemented (see groups, eg)
  • Logic is implemented within the Rhai wrapper that should probably be pushed up to the SDK (see send_near_internal, eg)
    • We should also check if the CLI is also doing its own logic to implement higher level operations and consolidate into the SDK
  • Use of "internal" functions when the "external" function does nothing but call it

Generally speaking, I think we should shoot for turning our Rhai functions into one liner wrappers around SDK functions, as far as that's possible.

WIP: https://forge.ourworld.tf/geomind_research/hero_ledger/src/branch/rhai_refactor

There is some room for improvement in the Rhai engine: - [x] Boilerplate code to call async (since Rhai can't do this natively) - Done via async wrappers, need to test more - [ ] Use of generic `call_function` where there should be an SDK function implemented (see groups, eg) - [ ] Logic is implemented within the Rhai wrapper that should probably be pushed up to the SDK (see `send_near_internal`, eg) - We should also check if the CLI is also doing its own logic to implement higher level operations and consolidate into the SDK - [ ] Use of "internal" functions when the "external" function does nothing but call it Generally speaking, I think we should shoot for turning our Rhai functions into one liner wrappers around SDK functions, as far as that's possible. WIP: https://forge.ourworld.tf/geomind_research/hero_ledger/src/branch/rhai_refactor
scott self-assigned this 2026-01-08 20:55:46 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
identity
rhai_refactor
v1.1.0
v1.0.0
Labels
Clear labels   
urgent
No labels
urgent
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
scott
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
geomind_research/hero_ledger#19
No description provided.