docs: Enhance MONOREPO_CONVERSION_PLAN.md with improved details
- Specify production-ready implementation details for sal-git package. - Add a detailed code review and quality assurance process section. - Include comprehensive success metrics and validation checklists for production readiness. - Improve security considerations and risk mitigation strategies. - Add stricter code review criteria based on sal-git's conversion. - Update README with security configurations and environment variables.
This commit is contained in:
@@ -137,3 +137,42 @@ fn test_git_executor_error_from_io_error() {
|
||||
_ => panic!("Expected CommandExecutionError variant"),
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_redis_url_configuration() {
|
||||
// Test default Redis URL
|
||||
std::env::remove_var("REDIS_URL");
|
||||
std::env::remove_var("SAL_REDIS_URL");
|
||||
|
||||
// This is testing the internal function, but we can't access it directly
|
||||
// Instead, we test that GitExecutor can be created without panicking
|
||||
let executor = GitExecutor::new();
|
||||
let _executor = executor; // Just verify it was created successfully
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_redis_url_from_environment() {
|
||||
// Test REDIS_URL environment variable
|
||||
std::env::set_var("REDIS_URL", "redis://test:6379/1");
|
||||
|
||||
// Create executor - should use the environment variable
|
||||
let executor = GitExecutor::new();
|
||||
let _executor = executor; // Just verify it was created successfully
|
||||
|
||||
// Clean up
|
||||
std::env::remove_var("REDIS_URL");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_sal_redis_url_from_environment() {
|
||||
// Test SAL_REDIS_URL environment variable (fallback)
|
||||
std::env::remove_var("REDIS_URL");
|
||||
std::env::set_var("SAL_REDIS_URL", "redis://sal-test:6379/2");
|
||||
|
||||
// Create executor - should use the SAL_REDIS_URL
|
||||
let executor = GitExecutor::new();
|
||||
let _executor = executor; // Just verify it was created successfully
|
||||
|
||||
// Clean up
|
||||
std::env::remove_var("SAL_REDIS_URL");
|
||||
}
|
||||
|
Reference in New Issue
Block a user