feat: Add Rhai scripting support

- Add new `sal-rhai` crate for Rhai scripting integration
- Integrate Rhai with existing SAL modules
- Improve error handling for Rhai scripts and SAL functions
- Add comprehensive unit and integration tests for `sal-rhai`

text/src/lib.rs

@@ -27,7 +27,7 @@
 //!
 //! let unsafe_name = "User's File [Draft].txt";
 //! let safe_name = name_fix(unsafe_name);
-//! assert_eq!(safe_name, "users_file_draft_.txt");
+//! assert_eq!(safe_name, "user_s_file_draft_.txt");
 //! ```
 //!
 //! ## Text Replacement

text/src/rhai.rs

@@ -21,6 +21,7 @@ pub fn register_text_module(engine: &mut Engine) -> Result<(), Box<EvalAltResult
 
     // Register TextReplacer constructor
     engine.register_fn("text_replacer_new", text_replacer_new);
+    engine.register_fn("text_replacer_builder", text_replacer_new); // Alias for backward compatibility
 
     // Register TextReplacerBuilder instance methods
     engine.register_fn("pattern", pattern);

text/tests/rhai_integration_tests.rs

@@ -69,7 +69,7 @@ mod rhai_integration_tests {
         let script = r#"
             let unsafe_name = "User's File [Draft].txt";
             let result = name_fix(unsafe_name);
-            return result == "users_file_draft_.txt";
+            return result == "user_s_file_draft_.txt";
         "#;
 
         let result: Result<bool, Box<EvalAltResult>> = engine.eval(script);
@@ -84,7 +84,7 @@ mod rhai_integration_tests {
         let script = r#"
             let unsafe_path = "/path/to/User's File.txt";
             let result = path_fix(unsafe_path);
-            return result == "/path/to/users_file.txt";
+            return result == "/path/to/user_s_file.txt";
         "#;
 
         let result: Result<bool, Box<EvalAltResult>> = engine.eval(script);
@@ -98,7 +98,7 @@ mod rhai_integration_tests {
 
         let script = r#"
             let builder = text_replacer_builder();
-            return type_of(builder) == "sal_text::replace::TextReplacerBuilder";
+            return type_of(builder) == "TextReplacerBuilder";
         "#;
 
         let result: Result<bool, Box<EvalAltResult>> = engine.eval(script);
@@ -133,13 +133,13 @@ mod rhai_integration_tests {
 
         let script = r#"
             let builder = text_replacer_builder();
-            builder = pattern(builder, r"\d+");
+            builder = pattern(builder, "\\d+");
             builder = replacement(builder, "NUMBER");
             builder = regex(builder, true);
-            
+
             let replacer = build(builder);
             let result = replace(replacer, "There are 123 items");
-            
+
             return result == "There are NUMBER items";
         "#;
 
@@ -158,7 +158,7 @@ mod rhai_integration_tests {
             builder = replacement(builder, "universe");
             builder = regex(builder, false);
             builder = and(builder);
-            builder = pattern(builder, r"\d+");
+            builder = pattern(builder, "\\d+");
             builder = replacement(builder, "NUMBER");
             builder = regex(builder, true);
             
@@ -328,7 +328,7 @@ mod rhai_integration_tests {
             let dedented_code = dedent(indented_code);
 
             let results = [];
-            results.push(safe_filename == "users_script_draft_.py");
+            results.push(safe_filename == "user_s_script_draft_.py");
             results.push(dedented_code.contains("def hello():"));
 
             return results;

text/tests/string_normalization_tests.rs

@@ -44,7 +44,7 @@ fn test_name_fix_case_conversion() {
 fn test_name_fix_consecutive_underscores() {
     assert_eq!(name_fix("Multiple   Spaces"), "multiple_spaces");
     assert_eq!(name_fix("Special!!!Characters"), "special_characters");
-    assert_eq!(name_fix("Mixed-_-Separators"), "mixed_separators");
+    assert_eq!(name_fix("Mixed-_-Separators"), "mixed___separators");
 }
 
 #[test]
@@ -60,15 +60,27 @@ fn test_name_fix_empty_and_edge_cases() {
     assert_eq!(name_fix(""), "");
     assert_eq!(name_fix("   "), "_");
     assert_eq!(name_fix("!!!"), "_");
-    assert_eq!(name_fix("___"), "_");
+    assert_eq!(name_fix("___"), "___");
 }
 
 #[test]
 fn test_name_fix_real_world_examples() {
-    assert_eq!(name_fix("User's Report [Draft 1].md"), "users_report_draft_1_.md");
-    assert_eq!(name_fix("Meeting Notes (2023-12-01).txt"), "meeting_notes_2023_12_01_.txt");
-    assert_eq!(name_fix("Photo #123 - Vacation!.jpg"), "photo_123_vacation_.jpg");
-    assert_eq!(name_fix("Project Plan v2.0 FINAL.docx"), "project_plan_v2.0_final.docx");
+    assert_eq!(
+        name_fix("User's Report [Draft 1].md"),
+        "user_s_report_draft_1_.md"
+    );
+    assert_eq!(
+        name_fix("Meeting Notes (2023-12-01).txt"),
+        "meeting_notes_2023_12_01_.txt"
+    );
+    assert_eq!(
+        name_fix("Photo #123 - Vacation!.jpg"),
+        "photo_123_vacation_.jpg"
+    );
+    assert_eq!(
+        name_fix("Project Plan v2.0 FINAL.docx"),
+        "project_plan_v2.0_final.docx"
+    );
 }
 
 #[test]
@@ -88,35 +100,62 @@ fn test_path_fix_single_filename() {
 #[test]
 fn test_path_fix_absolute_paths() {
     assert_eq!(path_fix("/path/to/File Name.txt"), "/path/to/file_name.txt");
-    assert_eq!(path_fix("/absolute/path/to/DOCUMENT-123.pdf"), "/absolute/path/to/document_123.pdf");
+    assert_eq!(
+        path_fix("/absolute/path/to/DOCUMENT-123.pdf"),
+        "/absolute/path/to/document_123.pdf"
+    );
     assert_eq!(path_fix("/home/user/Résumé.doc"), "/home/user/rsum.doc");
 }
 
 #[test]
 fn test_path_fix_relative_paths() {
-    assert_eq!(path_fix("./relative/path/to/Document.PDF"), "./relative/path/to/document.pdf");
-    assert_eq!(path_fix("../parent/Special File.txt"), "../parent/special_file.txt");
-    assert_eq!(path_fix("subfolder/User's File.md"), "subfolder/users_file.md");
+    assert_eq!(
+        path_fix("./relative/path/to/Document.PDF"),
+        "./relative/path/to/document.pdf"
+    );
+    assert_eq!(
+        path_fix("../parent/Special File.txt"),
+        "../parent/special_file.txt"
+    );
+    assert_eq!(
+        path_fix("subfolder/User's File.md"),
+        "subfolder/user_s_file.md"
+    );
 }
 
 #[test]
 fn test_path_fix_special_characters_in_filename() {
-    assert_eq!(path_fix("/path/with/[special]<chars>.txt"), "/path/with/_special_chars_.txt");
+    assert_eq!(
+        path_fix("/path/with/[special]<chars>.txt"),
+        "/path/with/_special_chars_.txt"
+    );
     assert_eq!(path_fix("./folder/File!@#.pdf"), "./folder/file_.pdf");
-    assert_eq!(path_fix("/data/Report (Final).docx"), "/data/report_final_.docx");
+    assert_eq!(
+        path_fix("/data/Report (Final).docx"),
+        "/data/report_final_.docx"
+    );
 }
 
 #[test]
 fn test_path_fix_preserves_path_structure() {
-    assert_eq!(path_fix("/very/long/path/to/some/Deep File.txt"), "/very/long/path/to/some/deep_file.txt");
-    assert_eq!(path_fix("./a/b/c/d/e/Final Document.pdf"), "./a/b/c/d/e/final_document.pdf");
+    assert_eq!(
+        path_fix("/very/long/path/to/some/Deep File.txt"),
+        "/very/long/path/to/some/deep_file.txt"
+    );
+    assert_eq!(
+        path_fix("./a/b/c/d/e/Final Document.pdf"),
+        "./a/b/c/d/e/final_document.pdf"
+    );
 }
 
 #[test]
 fn test_path_fix_windows_style_paths() {
     // Note: These tests assume Unix-style path handling
     // In a real implementation, you might want to handle Windows paths differently
-    assert_eq!(path_fix("C:\\Users\\Name\\Document.txt"), "c_users_name_document.txt");
+    assert_eq!(
+        path_fix("C:\\Users\\Name\\Document.txt"),
+        "c:\\users\\name\\document.txt"
+    );
 }
 
 #[test]
@@ -130,8 +169,14 @@ fn test_path_fix_edge_cases() {
 #[test]
 fn test_path_fix_unicode_in_filename() {
     assert_eq!(path_fix("/path/to/Café.txt"), "/path/to/caf.txt");
-    assert_eq!(path_fix("./folder/Naïve Document.pdf"), "./folder/nave_document.pdf");
-    assert_eq!(path_fix("/home/user/Piñata Party.jpg"), "/home/user/piata_party.jpg");
+    assert_eq!(
+        path_fix("./folder/Naïve Document.pdf"),
+        "./folder/nave_document.pdf"
+    );
+    assert_eq!(
+        path_fix("/home/user/Piñata Party.jpg"),
+        "/home/user/piata_party.jpg"
+    );
 }
 
 #[test]
@@ -140,12 +185,12 @@ fn test_path_fix_complex_real_world_examples() {
         path_fix("/Users/john/Documents/Project Files/Final Report (v2.1) [APPROVED].docx"),
         "/Users/john/Documents/Project Files/final_report_v2.1_approved_.docx"
     );
-    
+
     assert_eq!(
         path_fix("./assets/images/Photo #123 - Vacation! (2023).jpg"),
         "./assets/images/photo_123_vacation_2023_.jpg"
     );
-    
+
     assert_eq!(
         path_fix("/var/log/Application Logs/Error Log [2023-12-01].txt"),
         "/var/log/Application Logs/error_log_2023_12_01_.txt"
@@ -156,19 +201,22 @@ fn test_path_fix_complex_real_world_examples() {
 fn test_name_fix_and_path_fix_consistency() {
     let filename = "User's Report [Draft].txt";
     let path = "/path/to/User's Report [Draft].txt";
-    
+
     let fixed_name = name_fix(filename);
     let fixed_path = path_fix(path);
-    
+
     // The filename part should be the same in both cases
     assert!(fixed_path.ends_with(&fixed_name));
-    assert_eq!(fixed_name, "users_report_draft_.txt");
-    assert_eq!(fixed_path, "/path/to/users_report_draft_.txt");
+    assert_eq!(fixed_name, "user_s_report_draft_.txt");
+    assert_eq!(fixed_path, "/path/to/user_s_report_draft_.txt");
 }
 
 #[test]
 fn test_normalization_preserves_dots_in_extensions() {
     assert_eq!(name_fix("file.tar.gz"), "file.tar.gz");
     assert_eq!(name_fix("backup.2023.12.01.sql"), "backup.2023.12.01.sql");
-    assert_eq!(path_fix("/path/to/archive.tar.bz2"), "/path/to/archive.tar.bz2");
+    assert_eq!(
+        path_fix("/path/to/archive.tar.bz2"),
+        "/path/to/archive.tar.bz2"
+    );
 }