feat: Migrate SAL to Cargo workspace

- Migrate individual modules to independent crates
- Refactor dependencies for improved modularity
- Update build system and testing infrastructure
- Update documentation to reflect new structure

virt/src/rhai/nerdctl.rs

@@ -2,12 +2,14 @@
 //!
 //! This module provides Rhai wrappers for the functions in the Nerdctl module.
 
-use rhai::{Engine, EvalAltResult, Array, Dynamic, Map};
-use crate::nerdctl::{self, NerdctlError, Image, Container};
+use crate::nerdctl::{self, Container, Image, NerdctlError};
+use rhai::{Array, Dynamic, Engine, EvalAltResult, Map};
 use sal_process::CommandResult;
 
 // Helper functions for error conversion with improved context
-fn nerdctl_error_to_rhai_error<T>(result: Result<T, NerdctlError>) -> Result<T, Box<EvalAltResult>> {
+fn nerdctl_error_to_rhai_error<T>(
+    result: Result<T, NerdctlError>,
+) -> Result<T, Box<EvalAltResult>> {
     result.map_err(|e| {
         // Create a more detailed error message based on the error type
         let error_message = match &e {
@@ -27,7 +29,6 @@ fn nerdctl_error_to_rhai_error<T>(result: Result<T, NerdctlError>) -> Result<T,
                 format!("Nerdctl error: {}. This is an unexpected error.", msg)
             },
         };
-        
         Box::new(EvalAltResult::ErrorRuntime(
             error_message.into(),
             rhai::Position::NONE
@@ -160,7 +161,7 @@ pub fn container_with_health_check_options(
     interval: Option<&str>,
     timeout: Option<&str>,
     retries: Option<i64>,
-    start_period: Option<&str>
+    start_period: Option<&str>,
 ) -> Container {
     // Convert i64 to u32 for retries
     let retries_u32 = retries.map(|r| r as u32);
@@ -184,41 +185,49 @@ pub fn container_with_detach(container: Container, detach: bool) -> Container {
 pub fn container_build(container: Container) -> Result<Container, Box<EvalAltResult>> {
     // Get container details for better error reporting
     let container_name = container.name.clone();
-    let image = container.image.clone().unwrap_or_else(|| "none".to_string());
+    let image = container
+        .image
+        .clone()
+        .unwrap_or_else(|| "none".to_string());
     let ports = container.ports.clone();
     let volumes = container.volumes.clone();
     let env_vars = container.env_vars.clone();
-    
+
     // Try to build the container
     let build_result = container.build();
-    
+
     // Handle the result with improved error context
     match build_result {
         Ok(built_container) => {
             // Container built successfully
             Ok(built_container)
-        },
+        }
         Err(err) => {
             // Add more context to the error
             let enhanced_error = match err {
                 NerdctlError::CommandFailed(msg) => {
                     // Provide more detailed error information
-                    let mut enhanced_msg = format!("Failed to build container '{}' from image '{}': {}", 
-                        container_name, image, msg);
-                    
+                    let mut enhanced_msg = format!(
+                        "Failed to build container '{}' from image '{}': {}",
+                        container_name, image, msg
+                    );
+
                     // Add information about configured options that might be relevant
                     if !ports.is_empty() {
                         enhanced_msg.push_str(&format!("\nConfigured ports: {:?}", ports));
                     }
-                    
+
                     if !volumes.is_empty() {
                         enhanced_msg.push_str(&format!("\nConfigured volumes: {:?}", volumes));
                     }
-                    
+
                     if !env_vars.is_empty() {
-                        enhanced_msg.push_str(&format!("\nConfigured environment variables: {:?}", env_vars));
+                        enhanced_msg.push_str(&format!(
+                            "\nConfigured environment variables: {:?}",
+                            env_vars
+                        ));
                     }
-                    
+
                     // Add suggestions for common issues
                     if msg.contains("not found") || msg.contains("no such image") {
                         enhanced_msg.push_str("\nSuggestion: The specified image may not exist or may not be pulled yet. Try pulling the image first with nerdctl_image_pull().");
@@ -227,12 +236,12 @@ pub fn container_build(container: Container) -> Result<Container, Box<EvalAltRes
                     } else if msg.contains("permission denied") {
                         enhanced_msg.push_str("\nSuggestion: Permission issues detected. Check if you have the necessary permissions to create containers or access the specified volumes.");
                     }
-                    
+
                     NerdctlError::CommandFailed(enhanced_msg)
-                },
-                _ => err
+                }
+                _ => err,
             };
-            
+
             nerdctl_error_to_rhai_error(Err(enhanced_error))
         }
     }
@@ -246,17 +255,20 @@ pub fn container_build(container: Container) -> Result<Container, Box<EvalAltRes
 pub fn container_start(container: &mut Container) -> Result<CommandResult, Box<EvalAltResult>> {
     // Get container details for better error reporting
     let container_name = container.name.clone();
-    let container_id = container.container_id.clone().unwrap_or_else(|| "unknown".to_string());
-    
+    let container_id = container
+        .container_id
+        .clone()
+        .unwrap_or_else(|| "unknown".to_string());
+
     // Try to start the container
     let start_result = container.start();
-    
+
     // Handle the result with improved error context
     match start_result {
         Ok(result) => {
             // Container started successfully
             Ok(result)
-        },
+        }
         Err(err) => {
             // Add more context to the error
             let enhanced_error = match err {
@@ -270,21 +282,23 @@ pub fn container_start(container: &mut Container) -> Result<CommandResult, Box<E
                             code: 0,
                         });
                     }
-                    
+
                     // Try to get more information about why the container might have failed to start
-                    let mut enhanced_msg = format!("Failed to start container '{}' (ID: {}): {}", 
-                        container_name, container_id, msg);
-                    
+                    let mut enhanced_msg = format!(
+                        "Failed to start container '{}' (ID: {}): {}",
+                        container_name, container_id, msg
+                    );
+
                     // Try to check if the image exists
                     if let Some(image) = &container.image {
                         enhanced_msg.push_str(&format!("\nContainer was using image: {}", image));
                     }
-                    
+
                     NerdctlError::CommandFailed(enhanced_msg)
-                },
-                _ => err
+                }
+                _ => err,
             };
-            
+
             nerdctl_error_to_rhai_error(Err(enhanced_error))
         }
     }
@@ -301,7 +315,10 @@ pub fn container_remove(container: &mut Container) -> Result<CommandResult, Box<
 }
 
 /// Execute a command in the Container
-pub fn container_exec(container: &mut Container, command: &str) -> Result<CommandResult, Box<EvalAltResult>> {
+pub fn container_exec(
+    container: &mut Container,
+    command: &str,
+) -> Result<CommandResult, Box<EvalAltResult>> {
     nerdctl_error_to_rhai_error(container.exec(command))
 }
 
@@ -309,29 +326,34 @@ pub fn container_exec(container: &mut Container, command: &str) -> Result<Comman
 pub fn container_logs(container: &mut Container) -> Result<CommandResult, Box<EvalAltResult>> {
     // Get container details for better error reporting
     let container_name = container.name.clone();
-    let container_id = container.container_id.clone().unwrap_or_else(|| "unknown".to_string());
-    
+    let container_id = container
+        .container_id
+        .clone()
+        .unwrap_or_else(|| "unknown".to_string());
+
     // Use the nerdctl::logs function
     let logs_result = nerdctl::logs(&container_id);
-    
+
     match logs_result {
-        Ok(result) => {
-            Ok(result)
-        },
+        Ok(result) => Ok(result),
         Err(err) => {
             // Add more context to the error
-            let enhanced_error = NerdctlError::CommandFailed(
-                format!("Failed to get logs for container '{}' (ID: {}): {}",
-                    container_name, container_id, err)
-            );
-            
+            let enhanced_error = NerdctlError::CommandFailed(format!(
+                "Failed to get logs for container '{}' (ID: {}): {}",
+                container_name, container_id, err
+            ));
+
             nerdctl_error_to_rhai_error(Err(enhanced_error))
         }
     }
 }
 
 /// Copy files between the Container and local filesystem
-pub fn container_copy(container: &mut Container, source: &str, dest: &str) -> Result<CommandResult, Box<EvalAltResult>> {
+pub fn container_copy(
+    container: &mut Container,
+    source: &str,
+    dest: &str,
+) -> Result<CommandResult, Box<EvalAltResult>> {
     nerdctl_error_to_rhai_error(container.copy(source, dest))
 }
 
@@ -362,7 +384,11 @@ pub fn nerdctl_run_with_name(image: &str, name: &str) -> Result<CommandResult, B
 }
 
 /// Run a container with a port mapping
-pub fn nerdctl_run_with_port(image: &str, name: &str, port: &str) -> Result<CommandResult, Box<EvalAltResult>> {
+pub fn nerdctl_run_with_port(
+    image: &str,
+    name: &str,
+    port: &str,
+) -> Result<CommandResult, Box<EvalAltResult>> {
     let ports = vec![port];
     nerdctl_error_to_rhai_error(nerdctl::run(image, Some(name), true, Some(&ports), None))
 }
@@ -430,7 +456,10 @@ pub fn nerdctl_image_remove(image: &str) -> Result<CommandResult, Box<EvalAltRes
 /// Wrapper for nerdctl::image_push
 ///
 /// Push an image to a registry.
-pub fn nerdctl_image_push(image: &str, destination: &str) -> Result<CommandResult, Box<EvalAltResult>> {
+pub fn nerdctl_image_push(
+    image: &str,
+    destination: &str,
+) -> Result<CommandResult, Box<EvalAltResult>> {
     nerdctl_error_to_rhai_error(nerdctl::image_push(image, destination))
 }
 
@@ -451,14 +480,20 @@ pub fn nerdctl_image_pull(image: &str) -> Result<CommandResult, Box<EvalAltResul
 /// Wrapper for nerdctl::image_commit
 ///
 /// Commit a container to an image.
-pub fn nerdctl_image_commit(container: &str, image_name: &str) -> Result<CommandResult, Box<EvalAltResult>> {
+pub fn nerdctl_image_commit(
+    container: &str,
+    image_name: &str,
+) -> Result<CommandResult, Box<EvalAltResult>> {
     nerdctl_error_to_rhai_error(nerdctl::image_commit(container, image_name))
 }
 
 /// Wrapper for nerdctl::image_build
 ///
 /// Build an image using a Dockerfile.
-pub fn nerdctl_image_build(tag: &str, context_path: &str) -> Result<CommandResult, Box<EvalAltResult>> {
+pub fn nerdctl_image_build(
+    tag: &str,
+    context_path: &str,
+) -> Result<CommandResult, Box<EvalAltResult>> {
     nerdctl_error_to_rhai_error(nerdctl::image_build(tag, context_path))
 }
 
@@ -474,11 +509,11 @@ pub fn nerdctl_image_build(tag: &str, context_path: &str) -> Result<CommandResul
 pub fn register_nerdctl_module(engine: &mut Engine) -> Result<(), Box<EvalAltResult>> {
     // Register types
     register_nerdctl_types(engine)?;
-    
+
     // Register Container constructor
     engine.register_fn("nerdctl_container_new", container_new);
     engine.register_fn("nerdctl_container_from_image", container_from_image);
-    
+
     // Register Container instance methods
     engine.register_fn("reset", container_reset);
     engine.register_fn("with_port", container_with_port);
@@ -496,7 +531,10 @@ pub fn register_nerdctl_module(engine: &mut Engine) -> Result<(), Box<EvalAltRes
     engine.register_fn("with_network_aliases", container_with_network_aliases);
     engine.register_fn("with_memory_swap_limit", container_with_memory_swap_limit);
     engine.register_fn("with_cpu_shares", container_with_cpu_shares);
-    engine.register_fn("with_health_check_options", container_with_health_check_options);
+    engine.register_fn(
+        "with_health_check_options",
+        container_with_health_check_options,
+    );
     engine.register_fn("with_snapshotter", container_with_snapshotter);
     engine.register_fn("with_detach", container_with_detach);
     engine.register_fn("build", container_build);
@@ -506,7 +544,7 @@ pub fn register_nerdctl_module(engine: &mut Engine) -> Result<(), Box<EvalAltRes
     engine.register_fn("exec", container_exec);
     engine.register_fn("logs", container_logs);
     engine.register_fn("copy", container_copy);
-    
+
     // Register legacy container functions (for backward compatibility)
     engine.register_fn("nerdctl_run", nerdctl_run);
     engine.register_fn("nerdctl_run_with_name", nerdctl_run_with_name);
@@ -518,7 +556,7 @@ pub fn register_nerdctl_module(engine: &mut Engine) -> Result<(), Box<EvalAltRes
     engine.register_fn("nerdctl_remove", nerdctl_remove);
     engine.register_fn("nerdctl_list", nerdctl_list);
     engine.register_fn("nerdctl_logs", nerdctl_logs);
-    
+
     // Register image functions
     engine.register_fn("nerdctl_images", nerdctl_images);
     engine.register_fn("nerdctl_image_remove", nerdctl_image_remove);
@@ -527,7 +565,7 @@ pub fn register_nerdctl_module(engine: &mut Engine) -> Result<(), Box<EvalAltRes
     engine.register_fn("nerdctl_image_pull", nerdctl_image_pull);
     engine.register_fn("nerdctl_image_commit", nerdctl_image_commit);
     engine.register_fn("nerdctl_image_build", nerdctl_image_build);
-    
+
     Ok(())
 }
 
@@ -535,15 +573,16 @@ pub fn register_nerdctl_module(engine: &mut Engine) -> Result<(), Box<EvalAltRes
 fn register_nerdctl_types(engine: &mut Engine) -> Result<(), Box<EvalAltResult>> {
     // Register Container type
     engine.register_type_with_name::<Container>("NerdctlContainer");
-    
+
     // Register getters for Container properties
     engine.register_get("name", |container: &mut Container| container.name.clone());
-    engine.register_get("container_id", |container: &mut Container| {
-        match &container.container_id {
+    engine.register_get(
+        "container_id",
+        |container: &mut Container| match &container.container_id {
             Some(id) => id.clone(),
             None => "".to_string(),
-        }
-    });
+        },
+    );
     engine.register_get("image", |container: &mut Container| {
         match &container.image {
             Some(img) => img.clone(),
@@ -565,16 +604,16 @@ fn register_nerdctl_types(engine: &mut Engine) -> Result<(), Box<EvalAltResult>>
         array
     });
     engine.register_get("detach", |container: &mut Container| container.detach);
-    
+
     // Register Image type and methods
     engine.register_type_with_name::<Image>("NerdctlImage");
-    
+
     // Register getters for Image properties
     engine.register_get("id", |img: &mut Image| img.id.clone());
     engine.register_get("repository", |img: &mut Image| img.repository.clone());
     engine.register_get("tag", |img: &mut Image| img.tag.clone());
     engine.register_get("size", |img: &mut Image| img.size.clone());
     engine.register_get("created", |img: &mut Image| img.created.clone());
-    
+
     Ok(())
-}
+}