Correctness: Accept loop discards per-connection errors silently #118

New issue

Open

opened 2026-05-11 23:08:58 +00:00 by thabeta · 0 comments

thabeta commented

2026-05-11 23:08:58 +00:00

Owner

Severity: Medium

Location

crates/hero_aibroker_server/src/main.rs — accept_loop() and tcp_accept_loop()

Finding

Both accept loops discard per-connection errors:

tokio::spawn(async move {
    // ...
    let _ = hyper::server::conn::http1::Builder::new()
        .serve_connection(io, hyper_svc)
        .await;  // ERRORS SILENTLY DISCARDED
});

Impact

Connection failures are never logged
Cannot debug client-side issues
Cannot detect protocol violations
No visibility into connection-level errors

Recommendation

Log connection errors at debug level
Track connection error metrics
Alert on patterns of connection failures

## Severity: Medium ## Location `crates/hero_aibroker_server/src/main.rs` — `accept_loop()` and `tcp_accept_loop()` ## Finding Both accept loops discard per-connection errors: ```rust tokio::spawn(async move { // ... let _ = hyper::server::conn::http1::Builder::new() .serve_connection(io, hyper_svc) .await; // ERRORS SILENTLY DISCARDED }); ``` ## Impact - Connection failures are never logged - Cannot debug client-side issues - Cannot detect protocol violations - No visibility into connection-level errors ## Recommendation - Log connection errors at debug level - Track connection error metrics - Alert on patterns of connection failures