hero_rpc/hero_blueprint: absolute /Volumes/T7 paths + post-refactor breakage on development #152

New issue

Closed

opened 2026-06-01 10:32:45 +00:00 by zaelgohary · 2 comments

zaelgohary commented

2026-06-01 10:32:45 +00:00

Member

Three independent upstream issues found while pulling hero_rpc as a git dep from hero_os.

1. Absolute /Volumes/T7 paths in [patch] block (both branches)

Cargo.toml ships a [patch."hero_lib.git"] block pinning every herolib_* crate to /Volumes/T7/hero/code/hero_lib/.... That path only exists on one developer's machine; everywhere else cargo fails to resolve the workspace. Same pattern on development (3 entries) and refactor/hero-lib-base (6 entries).

Fix: PR #151 drops the block on refactor/hero-lib-base (workspace already lists the same crates as git deps).

The same bug is still present on development — Cargo.toml:50 plus the [patch] block at lines 73-76.

2. Broken derive crate on development

Commit 84feba6 ("refactor: move hero_lifecycle + oschema to hero_lib, drop line transport") deleted crates/derive/src/openrpc_client.rs and crates/derive/src/openrpc_proxy.rs but crates/derive/src/lib.rs still has:

mod openrpc_client;
mod openrpc_proxy;

Result: cargo check --workspace on development fails immediately with E0583 (file not found for module). Either restore the files or scrub the module declarations + dispatcher fns. refactor/hero-lib-base deletes the whole crates/derive/ directory, which is presumably the intended resolution.

3. Dead herolib_web dep

crates/osis/Cargo.toml declares herolib_web.workspace = true but no source file uses it. herolib_web no longer ships in hero_lib so the dep fails to resolve. Recommend removing it on both branches.

Suggested path forward

Merge #151 → refactor/hero-lib-base → development. Development is currently unbuildable due to (2); refactor/hero-lib-base builds clean once #151 lands.

Three independent upstream issues found while pulling hero_rpc as a git dep from hero_os. ## 1. Absolute /Volumes/T7 paths in [patch] block (both branches) `Cargo.toml` ships a `[patch."hero_lib.git"]` block pinning every herolib_* crate to `/Volumes/T7/hero/code/hero_lib/...`. That path only exists on one developer's machine; everywhere else cargo fails to resolve the workspace. Same pattern on `development` (3 entries) and `refactor/hero-lib-base` (6 entries). **Fix:** PR #151 drops the block on `refactor/hero-lib-base` (workspace already lists the same crates as git deps). The same bug is still present on `development` — `Cargo.toml:50` plus the `[patch]` block at lines 73-76. ## 2. Broken derive crate on development Commit `84feba6` ("refactor: move hero_lifecycle + oschema to hero_lib, drop line transport") deleted `crates/derive/src/openrpc_client.rs` and `crates/derive/src/openrpc_proxy.rs` but `crates/derive/src/lib.rs` still has: ``` mod openrpc_client; mod openrpc_proxy; ``` Result: `cargo check --workspace` on `development` fails immediately with E0583 (file not found for module). Either restore the files or scrub the module declarations + dispatcher fns. `refactor/hero-lib-base` deletes the whole `crates/derive/` directory, which is presumably the intended resolution. ## 3. Dead herolib_web dep `crates/osis/Cargo.toml` declares `herolib_web.workspace = true` but no source file uses it. `herolib_web` no longer ships in hero_lib so the dep fails to resolve. Recommend removing it on both branches. ## Suggested path forward Merge #151 → `refactor/hero-lib-base` → `development`. Development is currently unbuildable due to (2); refactor/hero-lib-base builds clean once #151 lands.

zaelgohary self-assigned this

2026-06-01 10:34:19 +00:00

zaelgohary commented

2026-06-01 10:34:36 +00:00

Author

Member

#151

https://forge.ourworld.tf/lhumina_code/hero_blueprint/pulls/151

zaelgohary closed this issue

2026-06-01 10:34:36 +00:00

zaelgohary referenced this issue from a commit

2026-06-01 10:48:51 +00:00

fix(cargo): drop absolute /Volumes/T7 patches and dead herolib_web dep

zaelgohary referenced this issue

2026-06-01 10:49:11 +00:00

fix(cargo): drop /Volumes/T7 patches and dead herolib_web dep #153

zaelgohary commented

2026-06-01 10:49:20 +00:00

Author

Member

Item 1 (absolute paths) and item 3 (dead herolib_web dep) are addressed by PR #153 against development. PR #151 already landed the same fix on refactor/hero-lib-base.

Item 2 (broken mod openrpc_client/proxy in crates/derive/src/lib.rs on development) is still open — leaving it to whoever owns the migration direction (restore the files vs. scrub the proc macros + dispatchers).

Item 1 (absolute paths) and item 3 (dead herolib_web dep) are addressed by PR #153 against development. PR #151 already landed the same fix on refactor/hero-lib-base. Item 2 (broken mod openrpc_client/proxy in crates/derive/src/lib.rs on development) is still open — leaving it to whoever owns the migration direction (restore the files vs. scrub the proc macros + dispatchers).