Generator: handle domain name collision with hand-impl module (e.g. `services` domain) #68

New issue

Closed

opened 2026-05-19 15:30:37 +00:00 by timur · 1 comment

timur commented

2026-05-19 15:30:37 +00:00

Owner

Context

Discovered by the #261 agent while bootstrapping hero_service. They chose services as the domain name (toy-domain = managing Hero services) and hit a collision because the generator emits a services module alongside the scaffolder's hand-impl src/services/mod.rs placeholder.

The collision forced the agent to work around the naming. Future contributors picking the obvious domain name will hit the same wall.

What to do

Pick one:

Rename the placeholder from src/services/ to something less generic (e.g. src/_handlers/ or src/business/).
Detect the collision in the scaffolder and either error out with a clear message ("domain name services collides with the placeholder; rename the domain or the placeholder") or auto-rename the placeholder.
Move the placeholder to a name that's a known reserved word the generator never emits as a domain.

Needs a small spec comment first deciding which approach + naming.

Acceptance

Scaffolding a service with domain name services (or any other plausible name) produces a clean workspace without manual renames.
Add a test that scaffolds with the conflicting name and verifies the result.

hero_skills#261.
Parent META: hero_skills#262.

## Context Discovered by the [#261 agent](https://forge.ourworld.tf/lhumina_code/hero_skills/issues/261#issuecomment-34264) while bootstrapping `hero_service`. They chose `services` as the domain name (toy-domain = managing Hero services) and hit a collision because the generator emits a `services` module alongside the scaffolder's hand-impl `src/services/mod.rs` placeholder. The collision forced the agent to work around the naming. Future contributors picking the obvious domain name will hit the same wall. ## What to do Pick one: - **Rename the placeholder** from `src/services/` to something less generic (e.g. `src/_handlers/` or `src/business/`). - **Detect the collision** in the scaffolder and either error out with a clear message ("domain name `services` collides with the placeholder; rename the domain or the placeholder") or auto-rename the placeholder. - **Move the placeholder** to a name that's a known reserved word the generator never emits as a domain. Needs a small spec comment first deciding which approach + naming. ## Acceptance - Scaffolding a service with domain name `services` (or any other plausible name) produces a clean workspace without manual renames. - Add a test that scaffolds with the conflicting name and verifies the result. ## Related - [hero_skills#261](https://forge.ourworld.tf/lhumina_code/hero_skills/issues/261). - Parent META: [hero_skills#262](https://forge.ourworld.tf/lhumina_code/hero_skills/issues/262).

timur referenced this issue from lhumina_code/hero_skills

2026-05-19 15:31:15 +00:00

[META] Standardize Hero service architecture — template, hero_rpc alignment, framework hoist, skills #262

timur referenced this issue

2026-05-19 16:47:01 +00:00

Don't generate empty src/services/ placeholder (subsumes #68) #75

timur referenced this issue from a commit

2026-05-19 23:42:14 +00:00

fix(generator): drop empty src/services/ placeholder (#75, closes #68)

timur referenced this issue

2026-05-19 23:42:28 +00:00

Don't generate empty src/services/ placeholder (subsumes #68) #75

timur commented

2026-05-19 23:42:38 +00:00

Author

Owner

Resolved by #75 / branch issue-75-remove-services-placeholder-v2 (1c2993df4b) — the empty src/services/ placeholder that was colliding with a services-named domain has been removed entirely from both the scaffolder and the build.rs codegen.

Verified by scaffolding a workspace with domain literally named services (hero_svctest) and building it clean — no manual fix-up required. The only pub mod services; in the resulting lib.rs is the feature-gated one for the domain itself; the src/services/ directory is populated entirely by codegen, with no placeholder.

Closing as resolved-by-this.

Resolved by #75 / branch `issue-75-remove-services-placeholder-v2` (1c2993df4b8f88a87fae3aa43aa5de9573b6ebed) — the empty `src/services/` placeholder that was colliding with a `services`-named domain has been removed entirely from both the scaffolder and the build.rs codegen. Verified by scaffolding a workspace with domain literally named `services` (`hero_svctest`) and building it clean — no manual fix-up required. The only `pub mod services;` in the resulting lib.rs is the feature-gated one for the domain itself; the `src/services/` directory is populated entirely by codegen, with no placeholder. Closing as resolved-by-this.

timur closed this issue

2026-05-19 23:42:39 +00:00

timur referenced this issue from a pull request that will close it,

2026-05-19 23:43:34 +00:00

fix(generator): drop empty src/services/ placeholder (#75, closes #68) #77

timur referenced this issue from a commit

2026-05-19 23:43:42 +00:00

fix(generator): drop empty src/services/ placeholder (#75, closes #68) (#77)