[hero_books] Adopt the memory service workspace field so book search returns results #139

Open
opened 2026-05-29 18:22:05 +00:00 by mik-tf · 0 comments
Owner

hero_books talks to the memory service using the older request shape and does not send the now required workspace field on collections.create, collections.scan, and memory.search (and still calls the removed namespace.create). Because the memory service now scopes every collection and query under a workspace, the documents hero_books indexes land in one scope while its searches look in another, so semantic search and book summaries come back empty even when indexing succeeded. The fix is to adopt the workspace model in hero_books: pick a workspace identity (the library or collection name works, one to one), create the workspace, and thread that workspace value through the create, scan, and search calls. The mismatching call sites are in crates/hero_books_lib/src/memory_client/mod.rs. This is the blocker for the end to end book summary flow.

hero_books talks to the memory service using the older request shape and does not send the now required workspace field on collections.create, collections.scan, and memory.search (and still calls the removed namespace.create). Because the memory service now scopes every collection and query under a workspace, the documents hero_books indexes land in one scope while its searches look in another, so semantic search and book summaries come back empty even when indexing succeeded. The fix is to adopt the workspace model in hero_books: pick a workspace identity (the library or collection name works, one to one), create the workspace, and thread that workspace value through the create, scan, and search calls. The mismatching call sites are in crates/hero_books_lib/src/memory_client/mod.rs. This is the blocker for the end to end book summary flow.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_books#139
No description provided.