lhumina_code/hero_compute
0
0
Fork 0
Code Issues 6 Pull requests Projects Releases 9 Packages Wiki Activity Actions

fix: show resource preview in non-explorer mode #85

Merged
nabil_salah merged 3 commits from development_fix_local_resource into development 2026-04-09 09:45:09 +00:00
Conversation 1 Commits 3 Files changed 1 +23 -1
nabil_salah commented 2026-04-08 14:40:04 +00:00
Member
Copy link

Summary

  • Resource preview in non-explorer mode: The deploy modal hid the resource preview card (RAM/Disk/vCPUs) in all non-explorer modes (local, master-local, worker) because _deployNodeData was never populated outside explorer mode. Now the deploy modal fetches the local node's resources via ComputeService.node_status and ComputeService.list_slices RPC calls, populates the preview, and shows the max slices hint — while keeping the node selector hidden (single-node context).

Changed files

  • crates/hero_compute_ui/static/js/dashboard.js — fetch local node data in non-explorer deploy modal to show resource preview

Test plan

  • Deploy VM modal in local mode shows resource preview (RAM, Disk, vCPUs)
  • Slice count hint shows "Max N slices available" in local mode
  • Verify on worker mode UI at http://worker-ip:9001

Resolves #79

## Summary - **Resource preview in non-explorer mode**: The deploy modal hid the resource preview card (RAM/Disk/vCPUs) in all non-explorer modes (local, master-local, worker) because `_deployNodeData` was never populated outside explorer mode. Now the deploy modal fetches the local node's resources via `ComputeService.node_status` and `ComputeService.list_slices` RPC calls, populates the preview, and shows the max slices hint — while keeping the node selector hidden (single-node context). ## Changed files - `crates/hero_compute_ui/static/js/dashboard.js` — fetch local node data in non-explorer deploy modal to show resource preview ## Test plan - [x] Deploy VM modal in local mode shows resource preview (RAM, Disk, vCPUs) - [x] Slice count hint shows "Max N slices available" in local mode - [x] Verify on worker mode UI at `http://worker-ip:9001` Resolves https://forge.ourworld.tf/lhumina_code/hero_compute/issues/79
feat(ui): fix showing local resources in the ui
All checks were successful
Test / test (push) Successful in 1m28s
Details
Test / test (pull_request) Successful in 1m28s
Details
2ac45ce43d 
Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>
fix: rpc endpoint needs lowercase
Some checks failed
Test / test (push) Failing after 1m20s
Details
Test / test (pull_request) Failing after 1m42s
Details
9e8e5e4528 
Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>
nabil_salah changed title from feat(ui): fix showing local resources in the ui to fix: show resource preview in non-explorer mode and normalize RPC method casing 2026-04-08 16:12:45 +00:00
fix: code lint and fmt
All checks were successful
Test / test (pull_request) Successful in 1m30s
Details
Test / test (push) Successful in 1m50s
Details
e9bca130fa 
Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>
Merge branch 'development' into development_fix_local_resource
All checks were successful
Test / test (push) Successful in 1m26s
Details
Test / test (pull_request) Successful in 1m48s
Details
c6eb3ab892
nabil_salah force-pushed development_fix_local_resource from c6eb3ab892
All checks were successful
Test / test (push) Successful in 1m26s
Details
Test / test (pull_request) Successful in 1m48s
Details
to e397d335c6
Some checks failed
Test / test (push) Has been cancelled
Details
Test / test (pull_request) Has been cancelled
Details
2026-04-09 09:10:18 +00:00 Compare
Merge branch 'development' into development_fix_local_resource
All checks were successful
Test / test (pull_request) Successful in 2m15s
Details
Test / test (push) Successful in 2m21s
Details
4c8cf3bed8
mahmoud approved these changes 2026-04-09 09:41:14 +00:00
mahmoud left a comment
Owner
Copy link

LGTM

LGTM
nabil_salah changed title from fix: show resource preview in non-explorer mode and normalize RPC method casing to fix: show resource preview in non-explorer mode 2026-04-09 09:43:38 +00:00
nabil_salah merged commit 2483fc7c67 into development 2026-04-09 09:45:09 +00:00
nabil_salah deleted branch development_fix_local_resource 2026-04-09 09:45:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mahmoud
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_compute!85
No description provided.