[tests] E2E integration tests need live stack — currently #[ignore]'d for CI; fix the --start/--stop CLI compat #14

New issue

Open

opened 2026-04-26 02:01:07 +00:00 by mik-tf · 0 comments

mik-tf commented

2026-04-26 02:01:07 +00:00

Owner

Symptom

crates/hero_indexer_examples/tests/integration.rs has 5 #[tokio::test] functions that all fail in CI with:

hero_indexer --start failed: error: unexpected argument '--start' found

The header comment for the file already explicitly says these tests need a live stack:

Integration tests — starts real server + UI, tests via SDK.

Requires: hero_proc running, binaries built and installed to ~/hero/bin/.

They should be #[ignore]'d so they don't fail CI; runnable on demand via cargo test -- --ignored on a dev box with the live setup.

Applied as part of the home#188 CI sweep PR ([hero_indexer#N — to be filled]).

What needs to happen

Either restore --start / --stop CLI subcommands on the hero_indexer binary (matching the test's expectations), OR rewrite the tests to not rely on the binary's CLI subcommand (e.g. start the server in-process for tests)
Once they can pass on a properly-configured dev box, document the setup steps in the test header
Verify they consistently pass before unmarking #[ignore]

Why they were #[ignore]'d not deleted

Unlike the hero_matrixchat case (where the test code referenced types that no longer exist), these tests compile fine — they just need a CLI subcommand that's been removed/renamed. The test logic is good; only the setup harness is broken. #[ignore] preserves the code for when the CLI is fixed; deletion would lose useful test scaffolding.

Parent: home#188 — Green CI on every Hero distribution repo

Signed-off-by: mik-tf

## Symptom `crates/hero_indexer_examples/tests/integration.rs` has 5 `#[tokio::test]` functions that all fail in CI with: ``` hero_indexer --start failed: error: unexpected argument '--start' found ``` The header comment for the file already explicitly says these tests need a live stack: > Integration tests — starts real server + UI, tests via SDK. > > Requires: hero_proc running, binaries built and installed to ~/hero/bin/. They should be `#[ignore]`'d so they don't fail CI; runnable on demand via `cargo test -- --ignored` on a dev box with the live setup. Applied as part of the [home#188](https://forge.ourworld.tf/lhumina_code/home/issues/188) CI sweep PR ([hero_indexer#N — to be filled]). ## What needs to happen - [ ] Either restore `--start` / `--stop` CLI subcommands on the `hero_indexer` binary (matching the test's expectations), OR rewrite the tests to not rely on the binary's CLI subcommand (e.g. start the server in-process for tests) - [ ] Once they can pass on a properly-configured dev box, document the setup steps in the test header - [ ] Verify they consistently pass before unmarking `#[ignore]` ## Why they were #[ignore]'d not deleted Unlike the hero_matrixchat case (where the test code referenced types that no longer exist), these tests **compile fine** — they just need a CLI subcommand that's been removed/renamed. The test logic is good; only the setup harness is broken. `#[ignore]` preserves the code for when the CLI is fixed; deletion would lose useful test scaffolding. ## Related - Parent: [home#188](https://forge.ourworld.tf/lhumina_code/home/issues/188) — Green CI on every Hero distribution repo Signed-off-by: mik-tf