Rhai improvements #19

New issue

Open

opened 2026-01-08 02:03:44 +00:00 by scott · 0 comments

scott commented

2026-01-08 02:03:44 +00:00

Member

There is some room for improvement in the Rhai engine:

Boilerplate code to call async (since Rhai can't do this natively)
- Done via async wrappers, need to test more
Use of generic call_function where there should be an SDK function implemented (see groups, eg)
Logic is implemented within the Rhai wrapper that should probably be pushed up to the SDK (see send_near_internal, eg)
- We should also check if the CLI is also doing its own logic to implement higher level operations and consolidate into the SDK
Use of "internal" functions when the "external" function does nothing but call it

Generally speaking, I think we should shoot for turning our Rhai functions into one liner wrappers around SDK functions, as far as that's possible.

WIP: https://forge.ourworld.tf/geomind_research/hero_ledger/src/branch/rhai_refactor

There is some room for improvement in the Rhai engine: - [x] Boilerplate code to call async (since Rhai can't do this natively) - Done via async wrappers, need to test more - [x] Use of generic `call_function` where there should be an SDK function implemented (see groups, eg) - [x] Logic is implemented within the Rhai wrapper that should probably be pushed up to the SDK (see `send_near_internal`, eg) - We should also check if the CLI is also doing its own logic to implement higher level operations and consolidate into the SDK - [ ] Use of "internal" functions when the "external" function does nothing but call it Generally speaking, I think we should shoot for turning our Rhai functions into one liner wrappers around SDK functions, as far as that's possible. WIP: https://forge.ourworld.tf/geomind_research/hero_ledger/src/branch/rhai_refactor