ci: enable 6 previously-uncovered crates, drop orphan oserver #132
No reviewers
Labels
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lhumina_code/hero_lib!132
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "development_cleanup_ci_coverage"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Re-enables 6 crates that had silently been skipped in CI.
Changes
Test coverage: 10 → 16 of 16 workspace crates
ci_rust.shonly tested 10 crates. A stale header comment disabledherolib_os,herolib_virt,herolib_sidfor reasons that no longer apply (verified locally);herolib_acp,herolib_tools,herolib_webserverwere silently uncovered. All six have passing tests — they are now in the PACKAGES list.Per-crate handling in the test runner:
herolib_os/herolib_acp/herolib_tools: skip doctests (live-git-URL assertions, missingrt-multi-threadfeature, missingtokio_testdev-dep respectively)herolib_virt: skip doctests + thenerdctl::container_testmodule (needs a running containerd daemon beyond what CI provides)Phantom entry removal
The stale disabled-crates comment referenced
herolib_osis— that crate does not exist in the workspace. Same pattern as theherolib_doghost entry removed in PR #131.Nit
Removed duplicate blank echo lines in
ci_rust.shfinal summary.Scope note
An earlier commit on this branch proposed removing
crates/oserver/(orphan — not in workspace members, no downstream consumers, only dep was the already-deletedherolib_osis). That removal was reverted pending decision on whether to revive the OSIS server work — see issue #97. No net change tocrates/oserver/on this PR.Verification
bash ci_rust.shlocally: 16/16 packages pass.Test plan
bash ci_rust.shlocally passes all 16 packages- Add herolib_acp, herolib_os, herolib_sid, herolib_tools, herolib_virt, herolib_webserver to ci_rust.sh PACKAGES (total: 10 → 16 of 16 workspace crates covered). - Remove phantom herolib_osis entry from disabled-crates comment; crate does not exist in the workspace. - Add per-crate handling in ci_rust.sh: - herolib_os / herolib_acp / herolib_tools: skip doctests (live git URL assertions, missing rt-multi-thread feature, missing tokio_test dev-dep) - herolib_virt: skip doctests + nerdctl::container_test module (needs a running containerd daemon beyond what CI provides) - Delete crates/oserver/ — orphan crate not in workspace members; its only dep (herolib_osis at ../osis) was already removed. Any future OSIS server work should track issue #97. - Remove duplicate echo cruft in ci_rust.sh final summary block. Local run: 16/16 packages pass.