Drop OO_SERVER_URL + obsolete CSP + scripts/nu_service.nu #18

New issue

Closed

opened 2026-04-27 10:29:59 +00:00 by zaelgohary · 0 comments

zaelgohary commented

2026-04-27 10:29:59 +00:00

Member

Symptom

Post-merge of #10 / #15 / #17, several pieces of the office stack are now dead weight:

OO_SERVER_URL is no longer read by any service. hero_office_server doesn't reference it; hero_office_ui only uses it to gate a CSP directive that's itself obsolete (OnlyOffice now generates URLs from X-Forwarded-Proto, so the scheme always matches).
scripts/nu_service.nu (278 lines) duplicates the hero_office --start/--stop selfstart CLI added in #10.
The CSP upgrade-insecure-requests block in the editor wrapper renderer is a no-op now that OnlyOffice's URLs match the page protocol.

Acceptance

OO_SERVER_URL is removed from hero_office_ui config + the selfstart CLI's forwarded env lists.
The CSP block is removed from the editor wrapper renderer.
scripts/nu_service.nu is deleted.
cargo fmt --check, cargo clippy -- -D warnings, and the office_editor_real playwright spec all pass.

## Symptom Post-merge of #10 / #15 / #17, several pieces of the office stack are now dead weight: - `OO_SERVER_URL` is no longer read by any service. `hero_office_server` doesn't reference it; `hero_office_ui` only uses it to gate a CSP directive that's itself obsolete (OnlyOffice now generates URLs from `X-Forwarded-Proto`, so the scheme always matches). - `scripts/nu_service.nu` (278 lines) duplicates the `hero_office --start/--stop` selfstart CLI added in #10. - The CSP `upgrade-insecure-requests` block in the editor wrapper renderer is a no-op now that OnlyOffice's URLs match the page protocol. ## Acceptance - `OO_SERVER_URL` is removed from `hero_office_ui` config + the selfstart CLI's forwarded env lists. - The CSP block is removed from the editor wrapper renderer. - `scripts/nu_service.nu` is deleted. - `cargo fmt --check`, `cargo clippy -- -D warnings`, and the office_editor_real playwright spec all pass.