Fix BASE_PATH regex for _ui suffix #12

Merged

mik-tf merged 6 commits from development_fix_basepath_regex into development 2026-03-05 15:14:29 +00:00

Conversation 0 Commits 6 Files changed 6 +17 -11

mik-tf commented 2026-03-04 23:59:07 +00:00

Owner

Copy link

Summary

• Update BASE_PATH JS regex from hero_\w+_http to hero_\w+_ui in base.html
• Required after service TOML rename from _http to _ui convention
• Ensures hero_proxy routing works correctly for the OSIS dashboard

Test plan

• Deploy container with updated hero_services TOMLs
• Access hero_osis_ui via hero_proxy and verify BASE_PATH resolves

## Summary - Update BASE_PATH JS regex from `hero_\w+_http` to `hero_\w+_ui` in `base.html` - Required after service TOML rename from `_http` to `_ui` convention - Ensures hero_proxy routing works correctly for the OSIS dashboard ## Test plan - [ ] Deploy container with updated hero_services TOMLs - [ ] Access hero_osis_ui via hero_proxy and verify BASE_PATH resolves

mik-tf added 2 commits 2026-03-04 23:59:07 +00:00

chore: bump rust-version to 1.93 per hero_ecosystem standard ... ff6c0b55cf

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: update BASE_PATH regex to match _ui suffix instead of _http ... 3b13db0dfe

The hero_proxy routes by /<service_name>/ prefix. With the rename
from _http to _ui, the JS BASE_PATH detection must match _ui.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf changed title from WIP: fix BASE_PATH regex for _ui suffix to Fix BASE_PATH regex for _ui suffix 2026-03-05 01:28:31 +00:00

mik-tf added 1 commit 2026-03-05 02:23:59 +00:00

fix: use hero_rpc branch with 2-part method dispatch support ... 8ffd3066e0

Point hero_rpc_osis dependency to development_fix_2part_dispatch branch
which supports both 2-part (Type.method) and 3-part (domain.Type.method)
method names in Unix socket dispatch. This fixes RPC calls from the
WASM UI which sends 2-part method names.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-03-05 02:46:26 +00:00

chore: update hero_rpc lock to two-phase dispatch fix ... f374943c25

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-03-05 03:02:24 +00:00

chore: update hero_rpc lock for error distinction fix ... ca046bbd1f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-03-05 13:31:23 +00:00

docs: add context pitfall warning to HERO_CONTEXTS arg ... 276b342b63

Document the recurring issue where hero_os_http looks up OSIS sockets
by context name and fails if only "root" is running but "default" is
requested.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf merged commit c93ae5566b into development 2026-03-05 15:14:29 +00:00

mik-tf referenced this pull request from a commit 2026-03-05 15:14:31 +00:00

Merge pull request 'Fix BASE_PATH regex for _ui suffix' (#12) from development_fix_basepath_regex into development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_osis!12

No description provided.