Remove dead duplicate dispatcher: crates/hero_proc_server/src/db/rpc.rs (no callers) #130

New issue

Closed

opened 2026-05-25 03:43:22 +00:00 by sameh-farouk · 0 comments

sameh-farouk commented

2026-05-25 03:43:22 +00:00

Member

What

crates/hero_proc_server/src/db/rpc.rs is a parallel RPC dispatcher module (~700+ LOC) that mirrors much of crates/hero_proc_server/src/rpc/mod.rs's dispatch shape. It's pub but has no in-tree callers — only its own doc-comment references it.

After #124's migration it was async-ified along with the rest of the codebase, doubling the maintenance surface for code that nobody actually uses.

Tasks

Confirm zero in-tree callers: grep -r 'db::rpc::' crates/hero_proc_server/src/ crates/hero_proc_sdk/ crates/hero_proc_admin/ crates/hero_proc_examples/.
Confirm zero out-of-tree callers via cross-org scan (101+ hero_* repos on Forgejo).
If both confirmed: delete the module + its test mod + the pub mod rpc; line in crates/hero_proc_server/src/db/mod.rs.
Otherwise: move to _archive/ or behind #[cfg(test)].

Scope

~750 LOC deletion if truly dead. Likely a quick win.

References

Found during external architect review of #124 (re-review v4): "Not introduced by this patch but the patch made it async, doubling the maintenance surface. Worth a removal/quarantine pass."

## What `crates/hero_proc_server/src/db/rpc.rs` is a parallel RPC dispatcher module (~700+ LOC) that mirrors much of `crates/hero_proc_server/src/rpc/mod.rs`'s `dispatch` shape. It's `pub` but has no in-tree callers — only its own doc-comment references it. After #124's migration it was async-ified along with the rest of the codebase, doubling the maintenance surface for code that nobody actually uses. ## Tasks 1. Confirm zero in-tree callers: `grep -r 'db::rpc::' crates/hero_proc_server/src/ crates/hero_proc_sdk/ crates/hero_proc_admin/ crates/hero_proc_examples/`. 2. Confirm zero out-of-tree callers via cross-org scan (101+ hero_* repos on Forgejo). 3. If both confirmed: delete the module + its test mod + the `pub mod rpc;` line in `crates/hero_proc_server/src/db/mod.rs`. 4. Otherwise: move to `_archive/` or behind `#[cfg(test)]`. ## Scope ~750 LOC deletion if truly dead. Likely a quick win. ## References - Found during external architect review of #124 (re-review v4): "Not introduced by this patch but the patch made it async, doubling the maintenance surface. Worth a removal/quarantine pass."