feat(osis): add rpc-core feature — defat server deps #23

Closed

timur wants to merge 1 commit from defat_osis_rpc into development

timur commented

2026-04-17 10:38:19 +00:00

Owner

Summary

Extract OsisAppRpcHandler + OsisAppWrapper from server.rs (3200 lines) into standalone app_handler.rs
Add rpc-core feature: lean traits/types only (no redis, no herolib_ai, no legacy AxumRpcServer)
Switch hero_rpc_server from osis[rpc] to osis[rpc-core]
Full rpc feature unchanged for backwards compat

Every downstream service (hero_osis, hero_books, hero_voice, hero_logic, hero_biz) no longer transitively compiles redis, deadpool-redis, herolib_ai, or the legacy Axum server.

Closes #22

Test plan

cargo check -p hero_rpc_osis --features rpc-core passes
cargo check -p hero_rpc_osis --features rpc passes (backwards compat)
cargo check -p hero_rpc_server passes
cargo check -p recipe_server passes
cargo check --workspace in hero_osis passes

🤖 Generated with Claude Code

## Summary - Extract `OsisAppRpcHandler` + `OsisAppWrapper` from `server.rs` (3200 lines) into standalone `app_handler.rs` - Add `rpc-core` feature: lean traits/types only (no redis, no herolib_ai, no legacy AxumRpcServer) - Switch `hero_rpc_server` from `osis[rpc]` to `osis[rpc-core]` - Full `rpc` feature unchanged for backwards compat Every downstream service (hero_osis, hero_books, hero_voice, hero_logic, hero_biz) no longer transitively compiles redis, deadpool-redis, herolib_ai, or the legacy Axum server. Closes #22 ## Test plan - [x] `cargo check -p hero_rpc_osis --features rpc-core` passes - [x] `cargo check -p hero_rpc_osis --features rpc` passes (backwards compat) - [x] `cargo check -p hero_rpc_server` passes - [x] `cargo check -p recipe_server` passes - [x] `cargo check --workspace` in hero_osis passes 🤖 Generated with [Claude Code](https://claude.com/claude-code)

timur added 1 commit

2026-04-17 10:38:19 +00:00

feat(osis): add rpc-core feature to decouple server from legacy deps

Test / test (push) Failing after 30s

Details

Test / test (pull_request) Failing after 31s

Details

1743e9e2fc

Extract OsisAppRpcHandler trait and OsisAppWrapper into app_handler.rs,
available via the new lean `rpc-core` feature. hero_rpc_server now
depends on osis[rpc-core] instead of osis[rpc], dropping transitive
redis, deadpool-redis, herolib_ai, and the 3200-line legacy AxumRpcServer
from every downstream service's build.

The full `rpc` feature remains for backwards compatibility.

Closes lhumina_code/hero_rpc#22

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

timur referenced this pull request from a commit

2026-04-19 14:59:05 +00:00

refactor(osis): defat — remove legacy RPC server, Redis, AI, remote index

timur referenced this pull request

2026-04-19 14:59:33 +00:00

refactor: ADR 001 — crate topology, OSIS defat, unified server, SDK UI #26

timur commented

2026-04-19 14:59:43 +00:00

Author

Owner

Superseded by PR #26 (refactor: ADR 001 — crate topology, OSIS defat, unified server, SDK UI).

PR #26 deletes the legacy code outright rather than gating it behind a feature — same goal, simpler endpoint. Closing this PR as obsolete.

Superseded by PR #26 (refactor: ADR 001 — crate topology, OSIS defat, unified server, SDK UI). PR #26 deletes the legacy code outright rather than gating it behind a feature — same goal, simpler endpoint. Closing this PR as obsolete.

timur closed this pull request

2026-04-19 14:59:44 +00:00