[P1] ~45 unsupervised `tokio::spawn` sites can panic/hang silently #38

New issue

Open

opened 2026-05-23 21:52:23 +00:00 by thabeta · 0 comments

thabeta commented

2026-05-23 21:52:23 +00:00

Owner

Problem
Long-lived background tasks (integration gateways, SSE chat, scheduler, hooks, MCP) are spawned without JoinError monitoring, restart, or even logging. Only proposer.rs has panic-isolation + backoff-restart.

Evidence

ARCHITECTURE_CLEANUP_PLAN.md (P0.2); crates/hero_shrimp_engine/src/agent_core/agent/proposer.rs is the template not applied broadly.

Proposed fix
Wrap supervised spawns in a helper that logs JoinError, and restarts (with backoff) the ones that should be durable.

Filed from a comparative audit of Hero Shrimp vs Qwen-Code / kimi-cli / picoclaw (2026-05-23). Severity in title: P0=correctness/trust, P1=reliability/UX, P2=cleanup.

**Problem** Long-lived background tasks (integration gateways, SSE chat, scheduler, hooks, MCP) are spawned without JoinError monitoring, restart, or even logging. Only `proposer.rs` has panic-isolation + backoff-restart. **Evidence** - `ARCHITECTURE_CLEANUP_PLAN.md` (P0.2); `crates/hero_shrimp_engine/src/agent_core/agent/proposer.rs` is the template not applied broadly. **Proposed fix** Wrap supervised spawns in a helper that logs JoinError, and restarts (with backoff) the ones that should be durable. --- _Filed from a comparative audit of Hero Shrimp vs Qwen-Code / kimi-cli / picoclaw (2026-05-23). Severity in title: P0=correctness/trust, P1=reliability/UX, P2=cleanup._