[P2] `CommandSucceeds` verify timeout (300s) is hardcoded, no circuit-breaker #44

New issue

Open

opened 2026-05-23 21:52:27 +00:00 by thabeta · 0 comments

thabeta commented

2026-05-23 21:52:27 +00:00

Owner

Problem
A hanging verify command blocks the whole job for 300s with no config override or early-out.

Evidence

crates/hero_shrimp_engine/src/verification/runner.rs COMMAND_TIMEOUT_SECS = 300.

Proposed fix
Make it configurable and add an early circuit-break / escalation path.

Filed from a comparative audit of Hero Shrimp vs Qwen-Code / kimi-cli / picoclaw (2026-05-23). Severity in title: P0=correctness/trust, P1=reliability/UX, P2=cleanup.

**Problem** A hanging verify command blocks the whole job for 300s with no config override or early-out. **Evidence** - `crates/hero_shrimp_engine/src/verification/runner.rs` `COMMAND_TIMEOUT_SECS = 300`. **Proposed fix** Make it configurable and add an early circuit-break / escalation path. --- _Filed from a comparative audit of Hero Shrimp vs Qwen-Code / kimi-cli / picoclaw (2026-05-23). Severity in title: P0=correctness/trust, P1=reliability/UX, P2=cleanup._