fix(ui): replace workspace divergence toast with persistent banner #70

Merged

salmaelsoly merged 8 commits from development_workspace_divergence_banner into development 2026-06-02 13:39:02 +00:00

Conversation 0 Commits 8 Files changed 7 +137 -48

salmaelsoly commented 2026-06-01 12:29:55 +00:00

Member

Copy link

Summary

• Replace the transient 4-second toast for workspace-path divergence with a persistent WorkspaceDivergenceBanner attached to the assistant message
• Add requested_workspace_path to the message.send RPC response so the UI has a server-authoritative signal for divergence detection
• Extend the Msg type with workspaceDivergence?: { wanted, got } so banner state survives re-renders
• New WorkspaceDivergenceBanner component: persistent red-bordered panel with both paths, explanation, and a "Fix workspace" button

Related Issue

Closes #41

Changes

• crates/hero_shrimp_server/src/rpc/methods/session.rs — emit requested_workspace_path alongside workspace_path in the include_workspace_in_response block
• crates/hero_shrimp_web/ui/src/store.ts — add workspaceDivergence field to Msg; replace toast() with setMessages attachment; prefer server-supplied field with client-side heuristic fallback
• crates/hero_shrimp_web/ui/src/components/WorkspaceDivergenceBanner.tsx (new) — persistent banner component following StallBanner.tsx pattern
• crates/hero_shrimp_web/ui/src/components/ChatThread.tsx — render banner after incomplete-turn affordance, before job panel

Test Results

153/163 tests passed. All 10 failures are pre-existing environment issues unrelated to this PR (bubblewrap detection, missing sh/python3 in sandbox, malformed YAML in 5 SKILL.md files).

## Summary - Replace the transient 4-second toast for workspace-path divergence with a persistent `WorkspaceDivergenceBanner` attached to the assistant message - Add `requested_workspace_path` to the `message.send` RPC response so the UI has a server-authoritative signal for divergence detection - Extend the `Msg` type with `workspaceDivergence?: { wanted, got }` so banner state survives re-renders - New `WorkspaceDivergenceBanner` component: persistent red-bordered panel with both paths, explanation, and a "Fix workspace" button ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_shrimp/issues/41 ## Changes - `crates/hero_shrimp_server/src/rpc/methods/session.rs` — emit `requested_workspace_path` alongside `workspace_path` in the `include_workspace_in_response` block - `crates/hero_shrimp_web/ui/src/store.ts` — add `workspaceDivergence` field to `Msg`; replace `toast()` with `setMessages` attachment; prefer server-supplied field with client-side heuristic fallback - `crates/hero_shrimp_web/ui/src/components/WorkspaceDivergenceBanner.tsx` (new) — persistent banner component following `StallBanner.tsx` pattern - `crates/hero_shrimp_web/ui/src/components/ChatThread.tsx` — render banner after incomplete-turn affordance, before job panel ## Test Results 153/163 tests passed. All 10 failures are pre-existing environment issues unrelated to this PR (bubblewrap detection, missing `sh`/`python3` in sandbox, malformed YAML in 5 SKILL.md files).

salmaelsoly added 1 commit 2026-06-01 12:29:55 +00:00

fix(ui): replace workspace divergence toast with persistent banner ... 5014687a60

When the server runs a turn in a different directory than the operator
pinned, the UI now attaches a persistent WorkspaceDivergenceBanner to
the assistant message instead of showing a transient 4-second toast.
The banner remains visible, shows both the requested and actual paths,
and offers a direct "Fix workspace" button.

Server-side, the message.send response now includes
requested_workspace_path alongside workspace_path so the client can
compare server-authoritative fields rather than relying solely on the
client-side normalization heuristic.

#41

salmaelsoly referenced this pull request 2026-06-01 12:30:22 +00:00

[P1] Workspace-path bind failure only warns; silently falls back to sandbox #41

salmaelsoly added 1 commit 2026-06-02 07:58:16 +00:00

chore(ui): rebuild frontend bundle with workspace divergence banner ... b744a5dbc4

Compiled output for the workspace divergence banner changes.

salmaelsoly force-pushed development_workspace_divergence_banner from b744a5dbc4 to d38dbd32c2 2026-06-02 07:58:59 +00:00 Compare

salmaelsoly added 1 commit 2026-06-02 09:03:35 +00:00

ci: pre-build eval binary in Build step to avoid OOM recompile 32844398eb

salmaelsoly added 1 commit 2026-06-02 09:19:08 +00:00

fix(ui): repair workspace divergence detection e22720bd32

salmaelsoly force-pushed development_workspace_divergence_banner from e22720bd32 to afe2c5a7a2 2026-06-02 09:40:26 +00:00 Compare

salmaelsoly added 1 commit 2026-06-02 11:55:58 +00:00

fix(ui): correct workspace divergence banner copy ca1508415d

salmaelsoly force-pushed development_workspace_divergence_banner from ca1508415d to 5358759e9a 2026-06-02 12:43:43 +00:00 Compare

salmaelsoly added 1 commit 2026-06-02 12:55:26 +00:00

ci: set RUST_MIN_STACK to stop flaky rustc SIGSEGV in engine codegen cb80d0eb90

salmaelsoly added 1 commit 2026-06-02 12:58:36 +00:00

ci: revert CI workflow changes 5ebb5d1a31

salmaelsoly merged commit f108c381e1 into development 2026-06-02 13:39:02 +00:00

salmaelsoly referenced this pull request from a commit 2026-06-02 13:39:03 +00:00

Merge pull request 'fix(ui): replace workspace divergence toast with persistent banner' (#70) from development_workspace_divergence_banner into development

salmaelsoly deleted branch development_workspace_divergence_banner 2026-06-02 13:39:12 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

prio_critical

  

prio_low

  

type_bug

  

type_contact

  

type_issue

  

type_lead

  

type_question

  

type_story

  

type_task

No labels

prio_critical

prio_low

type_bug

type_contact

type_issue

type_lead

type_question

type_story

type_task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_shrimp!70

No description provided.