fix(web): make budget indicator non-clickable info and style workspace dir as button #79

Merged

salmaelsoly merged 1 commit from development_budget_info_workspace_button into development

2026-06-03 11:17:41 +00:00

salmaelsoly commented

2026-06-02 14:08:32 +00:00

Member

Summary

Top status bar fixes per issue #77: the budget/cost indicator is now read-only informational text (no longer a button that opens Settings), and the workspace/target directory control is now a proper styled button consistent with the other nav buttons.

Closes #77

Changes

crates/hero_shrimp_web/ui/src/components/CostBadge.tsx: converted the root <button> to a non-interactive <div>; removed the Settings onClick and the unused setSettingsOpen import; dropped the .pill button styling for a plain info container; trimmed "click to edit budget" from the tooltip; updated the header comment. Spend/cap-percent/fuel-tank display unchanged.
crates/hero_shrimp_web/ui/src/components/TopBar.tsx: restyled the workspace/target control from bare clickable text to the shared .pill button style and relocated it alongside the primary nav pills; kept the setWorkspacePickerOpen click handler, folder icon, label, and sub-label.

Test Results

npm run build (vite) passes with no errors (99 modules, exit 0). The setSettingsOpen removal introduces no unused-import error; TopBar.tsx still uses it for the Settings gear. No backend/RPC changes.

## Summary Top status bar fixes per issue #77: the budget/cost indicator is now read-only informational text (no longer a button that opens Settings), and the workspace/target directory control is now a proper styled button consistent with the other nav buttons. ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_shrimp/issues/77 ## Changes - `crates/hero_shrimp_web/ui/src/components/CostBadge.tsx`: converted the root `<button>` to a non-interactive `<div>`; removed the Settings `onClick` and the unused `setSettingsOpen` import; dropped the `.pill` button styling for a plain info container; trimmed "click to edit budget" from the tooltip; updated the header comment. Spend/cap-percent/fuel-tank display unchanged. - `crates/hero_shrimp_web/ui/src/components/TopBar.tsx`: restyled the workspace/target control from bare clickable text to the shared `.pill` button style and relocated it alongside the primary nav pills; kept the `setWorkspacePickerOpen` click handler, folder icon, label, and sub-label. ## Test Results `npm run build` (vite) passes with no errors (99 modules, exit 0). The `setSettingsOpen` removal introduces no unused-import error; `TopBar.tsx` still uses it for the Settings gear. No backend/RPC changes. ![image](/attachments/b992ccac-51c2-49a9-b8e9-31ec394d370c)

image.png

7.9 KiB

salmaelsoly added 1 commit

2026-06-02 14:08:33 +00:00