lhumina_code/hero_skills
4
0
Fork 0
Code Issues 46 Pull requests Projects Releases 2 Packages 1 Wiki Activity Actions

lab/SERVICE_MAP: register hero_service (server + admin) #266

Merged
timur merged 1 commit from lab-add-hero-service into development 2026-05-19 15:28:18 +00:00
Conversation 0 Commits 1 Files changed 1 +5
timur commented 2026-05-19 15:18:44 +00:00
Owner
Copy link

Summary

  • Adds hero_service (server + admin) to lab SERVICE_MAP so lab service hero_service --start works.
  • Required by hero_skills#261 (the new lhumina_code/hero_service template repo).
  • Same shape as every other multi-binary entry (e.g. hero_proc, hero_code); start order is server → admin.

Test plan

  • cargo build -p lab --bin lab clean.
  • lab service hero_proc --start boots the supervisor.
  • lab service hero_service --install builds and installs both binaries into ~/hero/bin/.
  • lab service hero_service --start now finds both daemons (server + admin).
  • End-to-end smoke tests on both sockets pass (see hero_skills#261 final comment).

Longer-term plan already noted at service_manager.rs:441-444: replace the hardcoded table with dynamic discovery from each binarys embedded service.toml. Out of scope here.

## Summary - Adds `hero_service` (server + admin) to `lab` `SERVICE_MAP` so `lab service hero_service --start` works. - Required by hero_skills#261 (the new `lhumina_code/hero_service` template repo). - Same shape as every other multi-binary entry (e.g. `hero_proc`, `hero_code`); start order is server → admin. ## Test plan - [x] `cargo build -p lab --bin lab` clean. - [x] `lab service hero_proc --start` boots the supervisor. - [x] `lab service hero_service --install` builds and installs both binaries into `~/hero/bin/`. - [x] `lab service hero_service --start` now finds both daemons (server + admin). - [x] End-to-end smoke tests on both sockets pass (see hero_skills#261 final comment). Longer-term plan already noted at `service_manager.rs:441-444`: replace the hardcoded table with dynamic discovery from each binarys embedded `service.toml`. Out of scope here.
lab/SERVICE_MAP: register hero_service (server + admin)
Some checks failed
Build and Test (lab workspace) / build-and-test (pull_request) Failing after 2s
Details
c34e0fcec0
 
`lab service hero_service --start` was failing with
  "binary not found: '/Users/timurgordon/hero/bin/hero_service'"
because the new `lhumina_code/hero_service` template repo
(hero_skills#261) isn't in the hardcoded SERVICE_MAP.

Add it the same way as the other multi-binary services
(hero_proc, hero_code, hero_db, …): one entry, server first then admin
in start order. Verified via:
  lab service hero_proc --start       # boots supervisor
  lab service hero_service --install  # builds + installs both bins
  lab service hero_service --start    # lab now starts both daemons

The longer-term plan (already documented in the file header at line
441-444) is to replace this hardcoded table with dynamic discovery
from each binary's embedded service.toml.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
timur merged commit ba41747f6b into development 2026-05-19 15:28:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills!266
No description provided.