lhumina_code/hero_skills
4
0
Fork 0
Code Issues 34 Pull requests Projects Releases 1 Packages 1 Wiki Activity Actions

fix: update hero_ports registry with hero_launcher and port 8880 #5

Closed
mik-tf wants to merge 0 commits from development_heroports into development
pull from: development_heroports
merge into: lhumina_code:development
Conversation 3 Commits - Files changed -
mik-tf commented 2026-02-13 21:31:31 +00:00
Owner
Copy link

Summary

  • Add hero_launcher at port 3394 to hero_ports registry
  • Standardize hero_os port to 8880 (88xx frontend convention)

Test plan

  • hero_ports SKILL.md has correct port assignments
  • All registered ports match running services
## Summary - Add hero_launcher at port 3394 to hero_ports registry - Standardize hero_os port to 8880 (88xx frontend convention) ## Test plan - [ ] hero_ports SKILL.md has correct port assignments - [ ] All registered ports match running services
fix: standardize hero_os port to 8880 (88xx frontend convention)
Some checks failed
Test / test (pull_request) Failing after 1s
Details
163a12a00e 
- Replace hero_wasmos references with hero_os
- Align all port references to 8880 (was 3388/8201)
- hero_wasmos is archived, hero_os is the active frontend
fix: add hero_launcher at port 3394 to hero_ports registry
Some checks failed
Test / test (pull_request) Failing after 2s
Details
5d0c7e10ec
mik-tf changed title from fix: standardize hero_os port to 8880 to fix: update hero_ports registry with hero_launcher and port 8880 2026-02-14 04:44:14 +00:00
timur commented 2026-02-15 15:31:35 +00:00
Owner
Copy link

Hmm, i see two different approaches here.

@mik-tf you seem to have added a cli to manage validate skills: 45c9bee37a
@despiegk seems to have followed the single build_lib pattern in the workflow and use regular shell scripts for install etc.

i'm going in favor of the build_lib, to have a single script which we need to maintain that does everything, and because it seems to be less code eod. i think the cli might be a bit of overengineering in this case and might diverge us from having a single way of doing things, while its pretty neat and cool. But otherwise the changes to the skills are valid, will go on to merge them

Hmm, i see two different approaches here. @mik-tf you seem to have added a cli to manage validate skills: 45c9bee37a57c359e9919ede96d051629072b383 @despiegk seems to have followed the single build_lib pattern in the workflow and use regular shell scripts for install etc. i'm going in favor of the build_lib, to have a single script which we need to maintain that does everything, and because it seems to be less code eod. i think the cli might be a bit of overengineering in this case and might diverge us from having a single way of doing things, while its pretty neat and cool. But otherwise the changes to the skills are valid, will go on to merge them
👍 1
timur commented 2026-02-15 16:37:10 +00:00
Owner
Copy link

Merged selectively into development (commit 2773b2f).

Accepted:

  • hero_ports: hero_launcher port 3394, hero_os standardized to 8880
  • env_secrets: README pattern, best-effort sourcing in scripts, updated failure mode
  • hero_ui_dashboard: MCP connection info, metrics tracking, dynamic API docs from OpenRPC
  • herolib: frontmatter + workspace overview
  • makefile_helper: test-all convention (delegates to scripts/test-all.sh)
  • hero_ecosystem: archived hero_wasmos, updated hero_os entry

Rejected (favoring build_lib pattern over CLI):

  • geomindskills CLI script
  • geomind_skills/SKILL.md
  • INDEX.md deletion
  • README.md rewrite (was rewritten around CLI)
  • build.yaml changes
Merged selectively into development (commit 2773b2f). **Accepted:** - hero_ports: hero_launcher port 3394, hero_os standardized to 8880 - env_secrets: README pattern, best-effort sourcing in scripts, updated failure mode - hero_ui_dashboard: MCP connection info, metrics tracking, dynamic API docs from OpenRPC - herolib: frontmatter + workspace overview - makefile_helper: test-all convention (delegates to scripts/test-all.sh) - hero_ecosystem: archived hero_wasmos, updated hero_os entry **Rejected (favoring build_lib pattern over CLI):** - geomindskills CLI script - geomind_skills/SKILL.md - INDEX.md deletion - README.md rewrite (was rewritten around CLI) - build.yaml changes
timur closed this pull request 2026-02-15 16:37:11 +00:00
mik-tf commented 2026-02-16 15:00:47 +00:00
Author
Owner
Copy link

Thanks Timur! Good call.

I see we still have INDEX.md here, should we delete it then?

https://forge.ourworld.tf/geomind_code/dev_docs/src/branch/development/claude/skills/INDEX.md

Thanks Timur! Good call. I see we still have INDEX.md here, should we delete it then? https://forge.ourworld.tf/geomind_code/dev_docs/src/branch/development/claude/skills/INDEX.md
Some checks failed
Test / test (pull_request) Failing after 2s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills!5
No description provided.