fix(ui): resolve path issues when served behind hero_router #14

Merged

mahmoud merged 7 commits from development_fix_ui_path_resolution into development 2026-04-21 08:14:46 +00:00

Conversation 1 Commits 7 Files changed 36 +2893 -524

salmaelsoly commented 2026-04-19 08:39:02 +00:00

Member

Copy link

Summary

• Add dynamic base path resolution using X-Forwarded-Prefix header and <meta name="base-path"> tag injection
• Add missing /rpc proxy route to the UI Axum server
• Fix all hardcoded URL references in JavaScript (RPC, WebSocket, audio files, transforms, health checks)

Related Issue

Closes #10

Changes

• main.rs: Added BasePath struct, updated middleware to extract X-Forwarded-Prefix, added /rpc route with rpc_handler, modified serve_static to inject base-path meta tag into index.html
• app.js: Added BASE constant derived from meta tag with pathname fallback, prefixed all URL references (RPC, WebSocket, audio files, transforms) with BASE
• index.html: Changed script tag to ./app.js for explicit relative resolution, added base-path reading to inline health-check script, prefixed fetch() calls with base path

Test Results

• Build: pass
• Tests: 13 passed, 0 failed
  

## Summary - Add dynamic base path resolution using `X-Forwarded-Prefix` header and `<meta name="base-path">` tag injection - Add missing `/rpc` proxy route to the UI Axum server - Fix all hardcoded URL references in JavaScript (RPC, WebSocket, audio files, transforms, health checks) ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_voice/issues/10 ## Changes - **main.rs**: Added `BasePath` struct, updated middleware to extract `X-Forwarded-Prefix`, added `/rpc` route with `rpc_handler`, modified `serve_static` to inject base-path meta tag into `index.html` - **app.js**: Added `BASE` constant derived from meta tag with pathname fallback, prefixed all URL references (RPC, WebSocket, audio files, transforms) with `BASE` - **index.html**: Changed script tag to `./app.js` for explicit relative resolution, added base-path reading to inline health-check script, prefixed `fetch()` calls with base path ## Test Results - Build: pass - Tests: 13 passed, 0 failed 

image.png

308 KiB

salmaelsoly added 1 commit 2026-04-19 08:39:02 +00:00

fix(ui): resolve path issues when served behind hero_router ... aafc7fae9f

#10

salmaelsoly referenced this pull request 2026-04-19 08:39:11 +00:00

Voice UI broken when served behind hero_router — multiple path resolution issues #10

salmaelsoly changed title from fix(ui): resolve path issues when served behind hero_router to WIP: fix(ui): resolve path issues when served behind hero_router 2026-04-19 08:40:25 +00:00

salmaelsoly added 2 commits 2026-04-19 08:49:57 +00:00

fix(ci): replace checkout action with manual git clone for auth ... 401a5e671a

#10

style: cargo fmt across workspace d2118c3ae3

salmaelsoly added 1 commit 2026-04-19 08:55:26 +00:00

fix(ci): install libclang-dev and libespeak-ng-dev for bindgen ... b4fae2b502

#10

salmaelsoly force-pushed development_fix_ui_path_resolution from b4fae2b502 to c376ad400c 2026-04-19 09:17:23 +00:00 Compare

salmaelsoly force-pushed development_fix_ui_path_resolution from c376ad400c to 033824d61d 2026-04-19 09:17:36 +00:00 Compare

salmaelsoly added 1 commit 2026-04-19 09:29:14 +00:00

fix: resolve all clippy warnings across workspace ... 1072af1f30

#10

salmaelsoly force-pushed development_fix_ui_path_resolution from 1072af1f30 to 242cb89c91 2026-04-19 09:36:35 +00:00 Compare

salmaelsoly added 1 commit 2026-04-19 10:06:22 +00:00

fix(ui): rpc url and base path e36b81e8d6

salmaelsoly changed title from WIP: fix(ui): resolve path issues when served behind hero_router to fix(ui): resolve path issues when served behind hero_router 2026-04-19 10:12:47 +00:00

rawan commented 2026-04-20 08:59:10 +00:00

Member

Copy link

Tested, working when I opened hero voice UI from hero router

Tested, working when I opened hero voice UI from hero router 

image.png

85 KiB

salmaelsoly added 1 commit 2026-04-20 10:37:07 +00:00

fix(ui): improve base path handling and add HTML escaping for attributes 9f57781764

mahmoud merged commit 5f00bc92fb into development 2026-04-21 08:14:46 +00:00

mahmoud referenced this pull request from a commit 2026-04-21 08:14:49 +00:00

fix(ui): resolve path issues when served behind hero_router (#14)

mahmoud deleted branch development_fix_ui_path_resolution 2026-04-21 08:14:50 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

prio_critical

  

prio_low

  

type_bug

  

type_contact

  

type_issue

  

type_lead

  

type_question

  

type_story

  

type_task

No labels

prio_critical

prio_low

type_bug

type_contact

type_issue

type_lead

type_question

type_story

type_task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_voice!14

No description provided.