lhumina_code/hero_voice
22
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix: audio playback — wrong directory and .wav/.ogg mismatch #15

Merged
thabeta merged 4 commits from development_fix_audio_playback into development 2026-04-23 06:57:08 +00:00
Conversation 1 Commits 4 Files changed 9 +340 -85
salmaelsoly commented 2026-04-21 11:32:40 +00:00
Member
Copy link

Fixes #11

Summary

  • Use absolute data directory path
  • Handle .wav/.ogg extension mismatch in delete_audio
  • Register audio with .ogg extension
Fixes #11 ## Summary - Use absolute data directory path - Handle .wav/.ogg extension mismatch in delete_audio - Register audio with .ogg extension
fix: audio playback — wrong directory and .wav/.ogg mismatch
All checks were successful
Build / build (pull_request) Successful in 7m45s
Details
ba2350cfb5
salmaelsoly changed title from fix: audio playback — wrong directory and .wav/.ogg mismatch to WIP: fix: audio playback — wrong directory and .wav/.ogg mismatch 2026-04-21 14:30:02 +00:00
refactor: register-after-convert flow and centralize data_dir
Some checks failed
Build / build (pull_request) Failing after 6s
Details
149116d532
fix(voice): address review findings — no-collision filenames, cleanups
All checks were successful
Build / build (pull_request) Successful in 4m28s
Details
69ac2ea262
fix(voice): register wav immediately so recording appears in UI on stop
All checks were successful
Build / build (pull_request) Successful in 7m46s
Details
c8c07dd526
salmaelsoly changed title from WIP: fix: audio playback — wrong directory and .wav/.ogg mismatch to fix: audio playback — wrong directory and .wav/.ogg mismatch 2026-04-22 11:58:59 +00:00
nabil_salah commented 2026-04-22 13:27:42 +00:00
Member
Copy link

i tested with the pr branch and it is working fine recording and playing audio

image

i tested with the pr branch and it is working fine recording and playing audio ![image](/attachments/c75f4ec9-d18b-4439-b52b-89856897ce8c)
image.png
72 KiB
thabeta merged commit a52d4841f0 into development 2026-04-23 06:57:08 +00:00
salmaelsoly deleted branch development_fix_audio_playback 2026-04-23 06:57:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_voice!15
No description provided.