fix: resolve build errors for network domain #8

Merged

mik-tf merged 8 commits from fix/sdk-package-name into development 2026-02-04 00:31:05 +00:00

Conversation 0 Commits 8 Files changed 99 +29060 -4270

mik-tf commented 2026-02-04 00:01:42 +00:00

Owner

Copy link

• Fix SDK package name mismatch: add package = "hero_zero-sdk" to
  dev-dependency in Cargo.toml to match the name generated by build.rs
• Rename conflicting service methods in tfchain.oschema: get_balance ->
  get_tfchain_balance, get_node -> get_tfchain_node, get_farm ->
  get_tfchain_farm (avoids duplicate definitions with GridExplorer and
  Token services)
• Remove optional params (?) from grid.oschema service methods to work
  around herolib-osis code generator bug (doesn't wrap optional params
  in Some() in dispatchers). Use request types instead.
• Add GridGpuQuery type for GPU node discovery
• Add GridExplorerServiceHandler and TfChainServiceHandler stubs to
  network rpc.rs with todo!() implementations
• Regenerate all derived code

Build passes: cargo build --no-default-features --features network
Note: embedder domain has 74 pre-existing errors (unrelated API mismatch
with hero_embedder crate) that block full default build.

Note:** The development-tosort branch (TOSORT cleanup) should be rebased on top of this fix branch once both are merged, since the schemas were adjusted here. (see PR #7)

- Fix SDK package name mismatch: add package = "hero_zero-sdk" to dev-dependency in Cargo.toml to match the name generated by build.rs - Rename conflicting service methods in tfchain.oschema: get_balance -> get_tfchain_balance, get_node -> get_tfchain_node, get_farm -> get_tfchain_farm (avoids duplicate definitions with GridExplorer and Token services) - Remove optional params (?) from grid.oschema service methods to work around herolib-osis code generator bug (doesn't wrap optional params in Some() in dispatchers). Use request types instead. - Add GridGpuQuery type for GPU node discovery - Add GridExplorerServiceHandler and TfChainServiceHandler stubs to network rpc.rs with todo!() implementations - Regenerate all derived code Build passes: cargo build --no-default-features --features network Note: embedder domain has 74 pre-existing errors (unrelated API mismatch with hero_embedder crate) that block full default build. Note:** The `development-tosort` branch (TOSORT cleanup) should be rebased on top of this fix branch once both are merged, since the schemas were adjusted here. (see PR #7)

mik-tf added 1 commit 2026-02-04 00:01:43 +00:00

fix: resolve build errors for network domain ... 0a228e9ec3

- Fix SDK package name mismatch: add package = "hero_zero-sdk" to
  dev-dependency in Cargo.toml to match the name generated by build.rs
- Rename conflicting service methods in tfchain.oschema: get_balance ->
  get_tfchain_balance, get_node -> get_tfchain_node, get_farm ->
  get_tfchain_farm (avoids duplicate definitions with GridExplorer and
  Token services)
- Remove optional params (?) from grid.oschema service methods to work
  around herolib-osis code generator bug (doesn't wrap optional params
  in Some() in dispatchers). Use request types instead.
- Add GridGpuQuery type for GPU node discovery
- Add GridExplorerServiceHandler and TfChainServiceHandler stubs to
  network rpc.rs with todo!() implementations
- Regenerate all derived code

Build passes: cargo build --no-default-features --features network
Note: embedder domain has 74 pre-existing errors (unrelated API mismatch
with hero_embedder crate) that block full default build.

mik-tf referenced this pull request 2026-02-04 00:02:13 +00:00

refactor(network): sort TOSORT schemas into network domain #7

mik-tf added 1 commit 2026-02-04 00:07:20 +00:00

ci: fix build workflow ... 450e7d3fb5

- Use ghcr.io/despiegk/builder:latest instead of rust:latest
- Use actions/checkout@v4 instead of manual git clone (fixes PR checkout)
- Exclude embedder feature (requires ONNX runtime not in CI)
- Add source cargo env before all cargo commands
- Remove continue-on-error on clippy and fmt
- Remove hero_forge stub (not needed without webdav feature)
- Set permissions to read-only (no publish in this workflow)

mik-tf added 1 commit 2026-02-04 00:08:35 +00:00

style: apply cargo fmt to all generated and example code 6f4542c7c0

mik-tf added 1 commit 2026-02-04 00:09:52 +00:00

ci: move fmt check after build (build.rs regenerates code) 9ab9d6b0c2

mik-tf added 1 commit 2026-02-04 00:12:41 +00:00

ci: format generated code before fmt check ... d2f2e4d11f

build.rs generates unformatted Rust code during cargo build.
Run cargo fmt to format it before running cargo fmt --check,
so only actual source formatting issues are caught.

mik-tf added 1 commit 2026-02-04 00:16:31 +00:00

ci: consolidate build steps into single shell block ... fceaf1fafc

The Forgejo runner appears to merge separate run steps in a way that
prevents cargo fmt from taking effect before the check. Consolidate
build, format, check, and test into one shell block to guarantee
execution order.

mik-tf added 1 commit 2026-02-04 00:20:08 +00:00

ci: use cargo fmt --all to format all workspace crates 7d30685734

mik-tf added 1 commit 2026-02-04 00:23:59 +00:00

ci: use rustfmt directly on all .rs files ... 9970af5273

cargo fmt skips modules behind #[cfg(feature)] gates, so build.rs
generated code in cfg-gated domain modules never gets formatted.
Use find + rustfmt directly to format all .rs files.

mik-tf merged commit 54fba6ecce into development 2026-02-04 00:31:05 +00:00

mik-tf deleted branch fix/sdk-package-name 2026-02-04 00:31:06 +00:00

mik-tf referenced this pull request from a commit 2026-02-04 00:31:07 +00:00

Merge pull request 'fix: resolve build errors for network domain' (#8) from fix/sdk-package-name into development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_zero!8

No description provided.