port from zinit #1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
go back in history for https://forge.ourworld.tf/geomind_code/zinit
we probably need to go to SHA commit 79ae9e69468a40d29f113782c6abc0f17b0c827c
only get that code into this repo, don't have any history
and then start from there
redocument what is the toml format, make sure that all actions are against the toml files
make a clear overview of what is in the repo after removing above
make clear ARCHITECTURE.md doc so we can review
then after all of this we will check what needs to be done
Implementation Spec for Issue #1: Port from zinit
Objective
Port the zinit process supervisor codebase from
geomind_code/zinitat commit79ae9e69468a40d29f113782c6abc0f17b0c827cinto this repo without git history. Remove all job-related features. Confirm no ttyd code exists at that commit. Document TOML format and create ARCHITECTURE.md.Requirements
What Gets Removed (Jobs)
Files deleted entirely:
crates/zinit_server/src/jobs/(entire directory)crates/zinit_sdk/src/jobs.rscrates/zinit_examples/src/bin/03_jobs.rstests/integration/tests/jobs.rsFiles modified to remove job references:
crates/zinit_server/src/lib.rs,main.rs,ipc.rs,web.rscrates/zinit_sdk/src/lib.rscrates/zinit_server/openrpc.jsoncrates/zinit_ui/src/routes.rstests/integration/tests/main.rsWhat Remains After Cleanup
Implementation Plan (10 Steps)
cargo checkAcceptance Criteria
cargo checkpassesdocs/TOML_FORMAT.mddocuments all TOML config sectionsARCHITECTURE.mdprovides clear codebase overviewNotes
hero_rpc_deriveandherolib_clientsfrom forge.ourworld.tf (behindopenrpcfeature flag)Test Results
Compilation
cargo checkpasses cleanly with no errors or warningsTest Details
fixtures::tests::test_dependency_chain_creates_three_servicesfixtures::tests::test_dependent_service_serializesfixtures::tests::test_minimal_service_serializesharness::tests::test_harness_starts_and_stops— Pre-existing issue: test harness tries to launchzinit_serverfrom/Users/despiegk/hero/bin/zinit_server(system-installed binary), which may not match the current source. Not caused by our changes.Summary
All code changes compile cleanly. The one test failure is environmental (requires a pre-installed binary) and not related to the job removal work.
Implementation Summary
What was done
Ported zinit source at commit
79ae9e69468a40d29f113782c6abc0f17b0c827cinto this repo (no git history)Removed all job-related features:
crates/zinit_server/src/jobs/(4 files),crates/zinit_sdk/src/jobs.rs,crates/zinit_examples/src/bin/03_jobs.rs,tests/integration/tests/jobs.rszinit_server(lib.rs, main.rs, ipc.rs, web.rs),zinit_sdk(lib.rs, async_client.rs, zinit_client.rs),openrpc.json,zinit_ui/routes.rs, integration tests, examples Cargo.toml and MakefileNo ttyd code found at the target commit — confirmed no removal needed
Created documentation:
docs/TOML_FORMAT.md— Complete TOML service configuration referenceARCHITECTURE.md— High-level architecture overview of the codebaseCodebase after cleanup
Test results
cargo check: ✅ Clean compilationcargo test: 3/4 passed (1 pre-existing environmental failure unrelated to changes)Implementation Spec for Issue #1: Port from zinit and Cleanup
Objective
Port the zinit codebase from commit
79ae9e69468a40d29f113782c6abc0f17b0c827c(already done), remove all job-related features, confirm no ttyd code exists, and improve documentation (TOML format and Architecture).Requirements
zinit_server,zinit_sdk,zinit_examples, andtests.docs/TOML_FORMAT.md.ARCHITECTURE.md.Files to Modify/Create
To Delete:
crates/zinit_server/src/jobs/(entire directory)crates/zinit_sdk/src/jobs.rscrates/zinit_examples/src/bin/03_jobs.rstests/integration/tests/jobs.rsdocs/reference/zinit_jobs.oschemaTo Modify:
crates/zinit_server/src/lib.rs- removejobsmodule.crates/zinit_server/src/main.rs- removeJobManagerinitialization and arguments.crates/zinit_server/src/ipc.rs- remove job RPC handlers.crates/zinit_server/src/web.rs- remove job HTTP handlers and state.crates/zinit_server/src/supervisor.rs- remove any job-specific hooks or logic.crates/zinit_server/openrpc.json- remove job methods and schemas.crates/zinit_sdk/src/lib.rs- removejobsmodule and re-exports.crates/zinit_ui/src/routes.rs- remove job routes.tests/integration/tests/main.rs- remove job test module.crates/zinit_examples/Cargo.toml- remove03_jobsbinary.crates/zinit_examples/Makefile- removerun03.To Create:
docs/TOML_FORMAT.mdARCHITECTURE.mdImplementation Plan
Step 1: Delete job-related files
Files:
crates/zinit_server/src/jobs/crates/zinit_sdk/src/jobs.rscrates/zinit_examples/src/bin/03_jobs.rstests/integration/tests/jobs.rsdocs/reference/zinit_jobs.oschemaStep 2: Remove job references from zinit_sdk
Files:
crates/zinit_sdk/src/lib.rscrates/zinit_sdk/src/async_client.rs(if any)crates/zinit_sdk/src/zinit_client.rs(if any)Step 3: Remove job references from zinit_server
Files:
crates/zinit_server/src/lib.rscrates/zinit_server/src/main.rscrates/zinit_server/src/ipc.rscrates/zinit_server/src/web.rscrates/zinit_server/src/supervisor.rscrates/zinit_server/openrpc.jsonStep 4: Remove job references from UI, examples, and tests
Files:
crates/zinit_ui/src/routes.rstests/integration/tests/main.rscrates/zinit_examples/Cargo.tomlcrates/zinit_examples/MakefileStep 5: Verify compilation
Action: Run
cargo check.Step 6: Create TOML_FORMAT.md and ARCHITECTURE.md
Files:
docs/TOML_FORMAT.mdARCHITECTURE.mdAcceptance Criteria
cargo checkpasses.docs/TOML_FORMAT.mdcreated and accurate.ARCHITECTURE.mdcreated and provides a clear overview.Implementation Summary
What was done
79ae9e69468a40d29f113782c6abc0f17b0c827cinto this repo (no git history).crates/zinit_server/src/jobs/,crates/zinit_sdk/src/jobs.rs,crates/zinit_examples/src/bin/03_jobs.rs,tests/integration/tests/jobs.rs,docs/reference/zinit_jobs.oschema.zinit_server(lib.rs, main.rs, ipc.rs, web.rs),zinit_sdk(lib.rs, async_client.rs, zinit_client.rs),openrpc.json,zinit_ui/routes.rs, integration tests, examples Cargo.toml and Makefile.add-servicecommand now strictly requires a TOML file, ensuring all actions are against the TOML files as requested.docs/TOML_FORMAT.md— Complete TOML service configuration reference.ARCHITECTURE.md— High-level architecture overview.Test Results
cargo check: ✅ Clean compilation.cargo test: ✅ All integration tests passed (4 in main, 18 in service management, 7 in xinet, 5 in binary signals).Implementation committed:
1dbd721e9e674d05bbdbc22be9030c9eb4e0f8d6Browse:
1dbd721e9eImplementation committed (RE-COMMIT after sensitive file removal):
8e4d9115af29f594782778d9e50f22dda40c93b8Browse:
8e4d9115afImplementation committed:
f9269422742f061521c3c524ef0b6ce89999fd65Browse:
f926942274What was done
Final crate structure
Final Status Update
79ae9e6.