geomind_code/mycelium_network
22
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity Actions

Add the default quic listen port to the mobile package #5

Merged
lee merged 5 commits from master_support_quic into master 2026-01-05 09:55:27 +00:00
Conversation 3 Commits 5 Files changed 4 +437 -178
AhmedHanafy725 commented 2025-12-23 14:55:17 +00:00
Member
Copy link

Related issues

#3

### Related issues #3
Update mobile/src/lib.rs
Some checks failed
ci / check_fmt (pull_request) Failing after 3s
Details
ci / check_android_library (pull_request) Failing after 3s
Details
ci / clippy (ubuntu-latest) (pull_request) Failing after 8s
Details
ci / check_library (ubuntu-latest) (pull_request) Failing after 10s
Details
ci / check_flake (ubuntu-latest) (pull_request) Failing after 3s
Details
ci / check_binaries (myceliumd-private, ubuntu-latest) (pull_request) Failing after 11s
Details
ci / check_binaries (myceliumd, ubuntu-latest) (pull_request) Failing after 13s
Details
ci / clippy (macos-latest) (pull_request) Has been cancelled
Details
ci / clippy (windows-latest) (pull_request) Has been cancelled
Details
ci / check_library (macos-latest) (pull_request) Has been cancelled
Details
ci / check_library (windows-latest) (pull_request) Has been cancelled
Details
ci / check_ios_library (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, windows-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, windows-latest) (pull_request) Has been cancelled
Details
ci / check_flake (macos-latest) (pull_request) Has been cancelled
Details
61151de2ec 
Add the default quic listen port to the mobile package
Only enable the quic port if there are quic peers
Some checks failed
ci / check_fmt (pull_request) Failing after 4s
Details
ci / check_android_library (pull_request) Failing after 4s
Details
ci / clippy (ubuntu-latest) (pull_request) Failing after 10s
Details
ci / check_library (ubuntu-latest) (pull_request) Failing after 10s
Details
ci / check_flake (ubuntu-latest) (pull_request) Failing after 4s
Details
ci / check_binaries (myceliumd, ubuntu-latest) (pull_request) Failing after 12s
Details
ci / check_binaries (myceliumd-private, ubuntu-latest) (pull_request) Failing after 13s
Details
ci / check_library (macos-latest) (pull_request) Has been cancelled
Details
ci / check_library (windows-latest) (pull_request) Has been cancelled
Details
ci / check_ios_library (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, macos-latest) (pull_request) Has been cancelled
Details
ci / clippy (macos-latest) (pull_request) Has been cancelled
Details
ci / clippy (windows-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, windows-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, windows-latest) (pull_request) Has been cancelled
Details
ci / check_flake (macos-latest) (pull_request) Has been cancelled
Details
b27acd48ae
Fix installing crypto provider when it's already installed
Some checks failed
ci / check_fmt (pull_request) Failing after 4s
Details
ci / clippy (ubuntu-latest) (pull_request) Failing after 9s
Details
ci / check_android_library (pull_request) Failing after 3s
Details
ci / check_library (ubuntu-latest) (pull_request) Failing after 10s
Details
ci / check_flake (ubuntu-latest) (pull_request) Failing after 2s
Details
ci / check_binaries (myceliumd, ubuntu-latest) (pull_request) Failing after 12s
Details
ci / check_binaries (myceliumd-private, ubuntu-latest) (pull_request) Failing after 11s
Details
ci / clippy (macos-latest) (pull_request) Has been cancelled
Details
ci / clippy (windows-latest) (pull_request) Has been cancelled
Details
ci / check_library (macos-latest) (pull_request) Has been cancelled
Details
ci / check_library (windows-latest) (pull_request) Has been cancelled
Details
ci / check_ios_library (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, windows-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, windows-latest) (pull_request) Has been cancelled
Details
ci / check_flake (macos-latest) (pull_request) Has been cancelled
Details
a864aa81df
lee reviewed 2025-12-29 12:53:06 +00:00
mobile/src/lib.rs Outdated
@ -97,2 +109,3 @@
tcp_listen_port: DEFAULT_TCP_LISTEN_PORT,
quic_listen_port: None,
// Only enable QUIC port if there are QUIC peers
quic_listen_port: if has_quic_peers { Some(DEFAULT_QUIC_LISTEN_PORT) } else { None },
lee commented 2025-12-29 12:52:57 +00:00
Owner
Copy link

What is the reason this is only enabled if quic peers are configured and not always, so quic peers can be added without restart?

What is the reason this is only enabled if quic peers are configured and not always, so quic peers can be added without restart?
AhmedHanafy725 commented 2025-12-30 08:54:27 +00:00
Author
Member
Copy link

didn't know about adding the peer without a restart(opened an issue for it geomind_code/mycelium_network_gui#2) and reverted this part

didn't know about adding the peer without a restart(opened an issue for it https://forge.ourworld.tf/geomind_code/mycelium_network_gui/issues/2) and reverted this part
Revert "Only enable the quic port if there are quic peers"
Some checks failed
ci / check_binaries (myceliumd, ubuntu-latest) (pull_request) Failing after 12s
Details
ci / check_binaries (myceliumd-private, ubuntu-latest) (pull_request) Failing after 12s
Details
ci / check_library (windows-latest) (pull_request) Has been cancelled
Details
ci / check_ios_library (pull_request) Has been cancelled
Details
ci / clippy (macos-latest) (pull_request) Has been cancelled
Details
ci / clippy (windows-latest) (pull_request) Has been cancelled
Details
ci / check_library (macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd, windows-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, macos-latest) (pull_request) Has been cancelled
Details
ci / check_binaries (myceliumd-private, windows-latest) (pull_request) Has been cancelled
Details
ci / check_flake (macos-latest) (pull_request) Has been cancelled
Details
ci / check_fmt (push) Failing after 4s
Details
ci / check_android_library (push) Failing after 3s
Details
ci / clippy (ubuntu-latest) (push) Failing after 9s
Details
ci / check_library (ubuntu-latest) (push) Failing after 10s
Details
ci / check_flake (ubuntu-latest) (push) Failing after 3s
Details
Create and publish a Docker image / build-and-push-image (push) Failing after 6s
Details
ci / check_binaries (myceliumd-private, ubuntu-latest) (push) Failing after 12s
Details
ci / check_binaries (myceliumd, ubuntu-latest) (push) Failing after 13s
Details
ci / clippy (macos-latest) (push) Has been cancelled
Details
ci / clippy (windows-latest) (push) Has been cancelled
Details
ci / check_library (macos-latest) (push) Has been cancelled
Details
ci / check_library (windows-latest) (push) Has been cancelled
Details
ci / check_ios_library (push) Has been cancelled
Details
ci / check_binaries (myceliumd, macos-latest) (push) Has been cancelled
Details
ci / check_binaries (myceliumd, windows-latest) (push) Has been cancelled
Details
ci / check_binaries (myceliumd-private, macos-latest) (push) Has been cancelled
Details
ci / check_binaries (myceliumd-private, windows-latest) (push) Has been cancelled
Details
ci / check_flake (macos-latest) (push) Has been cancelled
Details
f56a212155 
This reverts commit b27acd48ae.
thabeta commented 2026-01-04 12:58:09 +00:00
Owner
Copy link

@lee please let's have this merged the soonest tmw

@lee please let's have this merged the soonest tmw
lee approved these changes 2026-01-05 09:55:20 +00:00
lee merged commit f56a212155 into master 2026-01-05 09:55:27 +00:00
lee deleted branch master_support_quic 2026-01-05 09:55:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
lee
Labels
Clear labels   
Urgent
No labels
Urgent
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
geomind_code/mycelium_network!5
No description provided.