geomind_code/webgateway
22
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

add-admin-interface #31

Merged
eslamnawara merged 9 commits from add-admin-interface into main 2026-03-03 13:27:07 +00:00
Conversation 2 Commits 9 Files changed 5 +879 -209
eslamnawara commented 2026-03-02 21:20:44 +00:00
Member
Copy link
No description provided.
fix lint
Some checks failed
Lint / lint (push) Failing after 1m10s
Details
Build / build (push) Successful in 10m18s
Details
Test / test (push) Successful in 10m19s
Details
8b0471aa63
update admin service to be service instead of id
All checks were successful
Lint / lint (push) Successful in 10m50s
Details
Test / test (push) Successful in 10m59s
Details
Build / build (push) Successful in 10m17s
Details
50f8587b03
eslamnawara force-pushed add-admin-interface from 50f8587b03
All checks were successful
Lint / lint (push) Successful in 10m50s
Details
Test / test (push) Successful in 10m59s
Details
Build / build (push) Successful in 10m17s
Details
to 4053556b75
All checks were successful
Build / build (push) Successful in 10m16s
Details
Test / test (push) Successful in 10m42s
Details
Lint / lint (push) Successful in 10m54s
Details
2026-03-02 22:14:28 +00:00 Compare
salmaelsoly requested changes 2026-03-03 10:12:53 +00:00
Dismissed
caddy/openrpc/methods.go Outdated
@ -66,0 +357,4 @@
}
}
// Parse parameters
salmaelsoly commented 2026-03-03 09:55:30 +00:00
Member
Copy link

can we extract this in helper function authenticateAdmin?

can we extract this in helper function authenticateAdmin?
caddy/openrpc/methods.go
@ -253,110 +593,27 @@ func (r *MethodRouter) handleMyceliumServicesUpdate(ctx context.Context, req *ht
}
salmaelsoly commented 2026-03-03 09:41:36 +00:00
Member
Copy link

can we check here firstly if the error is service notfound or not

can we check here firstly if the error is service notfound or not
salmaelsoly commented 2026-03-03 09:44:26 +00:00
Member
Copy link

check for delete service too

check for delete service too
eslamnawara commented 2026-03-03 11:05:32 +00:00
Author
Member
Copy link

this method just updates/delete the service, if you checked the functions calling it for example handleMyceliumServicesUpdate , they try to get the service and check their ownership before this update function is called

this method just updates/delete the service, if you checked the functions calling it for example `handleMyceliumServicesUpdate` , they try to get the service and check their ownership before this update function is called
👍 1
caddy/openrpc/spec.go
@ -264,0 +395,4 @@
},
{
"code": -32003,
"message": "Admin privileges required",
salmaelsoly commented 2026-03-03 10:02:03 +00:00
Member
Copy link

code should be -32002 for Forbidden can u check the rest

code should be -32002 for Forbidden can u check the rest
cmds/gwctl/main.go
@ -329,0 +425,4 @@
if len(backends) == 0 {
return fmt.Errorf("at least one --backend is required")
}
salmaelsoly commented 2026-03-03 10:06:01 +00:00
Member
Copy link

can we validate --method here as well?

can we validate --method here as well?
add method validation in gwctl
All checks were successful
Build / build (push) Successful in 10m13s
Details
Lint / lint (push) Successful in 10m45s
Details
Test / test (push) Successful in 10m17s
Details
adb69dcd60
eslamnawara deleted branch add-admin-interface 2026-03-03 13:27:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
salmaelsoly
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
geomind_code/webgateway!31
No description provided.