geomind_code/webgateway
22
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions

add-body-digest-validation #32

Merged
eslamnawara merged 7 commits from add-body-digest-validation into main 2026-03-10 21:28:50 +00:00
Conversation 2 Commits 7 Files changed 4 +192 -8
eslamnawara commented 2026-03-04 23:14:05 +00:00
Member
Copy link
No description provided.
add test
Some checks failed
Build / build (push) Successful in 10m18s
Details
Test / test (push) Successful in 10m23s
Details
Lint / lint (push) Failing after 5m56s
Details
42caaa5660
close origional request body
All checks were successful
Build / build (push) Successful in 10m40s
Details
Test / test (push) Successful in 10m41s
Details
Lint / lint (push) Successful in 11m1s
Details
c762a7200b
salmaelsoly requested changes 2026-03-08 10:09:36 +00:00
Dismissed
internal/httpsig/verifier.go Outdated
@ -85,0 +138,4 @@
case "SHA-512":
h := sha512.Sum512(body)
computedHash = h[:]
default:
salmaelsoly commented 2026-03-08 10:03:01 +00:00
Member
Copy link

can we extract strings here in constant and use it in the testcases too

can we extract strings here in constant and use it in the testcases too
internal/httpsig/verifier_test.go
@ -178,0 +277,4 @@
if err != nil {
assert.Contains(t, err.Error(), tt.expectedError)
}
} else {
salmaelsoly commented 2026-03-08 09:57:43 +00:00
Member
Copy link

i think we can remove this if err != nil since we already assert before it

i think we can remove this if err != nil since we already assert before it
extract algorithm strings to constants
All checks were successful
Build / build (push) Successful in 10m15s
Details
Test / test (push) Successful in 10m22s
Details
Lint / lint (push) Successful in 10m35s
Details
9942e801fd
restore request body in servehttp so that sig digest can read it
All checks were successful
Build / build (push) Successful in 10m17s
Details
Lint / lint (push) Successful in 10m34s
Details
Test / test (push) Successful in 10m18s
Details
44c355e1c6
Merge branch 'main' into add-body-digest-validation
Some checks failed
Build / build (push) Successful in 10m31s
Details
Lint / lint (push) Failing after 6m19s
Details
Test / test (push) Successful in 10m48s
Details
1035a00103
eslamnawara force-pushed add-body-digest-validation from 1035a00103
Some checks failed
Build / build (push) Successful in 10m31s
Details
Lint / lint (push) Failing after 6m19s
Details
Test / test (push) Successful in 10m48s
Details
to 8b9a6e733e
Some checks failed
Test / test (push) Successful in 2m32s
Details
Build / build (push) Successful in 10m17s
Details
Lint / lint (push) Failing after 1m0s
Details
2026-03-10 20:42:10 +00:00 Compare
fix lint
All checks were successful
Test / test (push) Successful in 10m24s
Details
Build / build (push) Successful in 10m40s
Details
Lint / lint (push) Successful in 11m0s
Details
cb73291875
eslamnawara deleted branch add-body-digest-validation 2026-03-10 21:29:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
salmaelsoly
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
geomind_code/webgateway!32
No description provided.