geomind_code/zinit
24
0
Fork 0
Code Issues 2 Pull requests 1 Projects Releases Packages 2 Wiki Activity Actions

development_stability #6

Open
despiegk wants to merge 0 commits from development_stability into development
pull from: development_stability
merge into: geomind_code:development
Conversation 0 Commits - Files changed -
despiegk commented 2026-01-23 09:18:20 +00:00
Owner
Copy link
No description provided. 
- Fix critical bug where petgraph's swap-remove strategy would invalidate
  NodeIndex values in our by_name HashMap after removing services
- When removing a node, petgraph moves the last node into the removed
  position, so we must update our by_name mapping accordingly
- Add stop_and_wait() for reliable service stopping: 5s SIGTERM graceful
  timeout, then SIGKILL, then 3s wait for process death
- Implement cascade removal: removing a parent service now removes all
  dependents first (most-dependent-first order)
- Add link_service_dependencies() to properly create graph edges for
  services added via API (not just loaded from config files)
- Fix serde_json::from_value panics in IPC by using proper error handling
- Add CascadeStopFailed and ConfigDeleteFailed error types
- Clean up log buffers, timers, and process tasks on service removal
- Add comprehensive integration tests for cascade removal, config file
  deletion, and complete memory cleanup after removal

All 135 unit tests and 57 integration tests pass.
- Replace synchronous TUI with event-driven async architecture
- Add Action/ActionResult pattern for decoupled UI operations
- Implement EventHandler with persistent intervals and biased select
- Add channel-based communication for async RPC calls
- Add timeout management for all operations (5s-60s based on type)
- Add reconnection handling for connection failures
- Fix poweroff/reboot commands to work on macOS (use RPC instead of PID 1 signal)
- Add children() method to AsyncZinitClient
- Export ChildProcessInfo from SDK
- Add TUI documentation and SKILL guide for async TUI development

New TUI module structure:
- src/client/tui/mod.rs - Entry point with tokio runtime
- src/client/tui/app.rs - Application state and key handling
- src/client/tui/actions.rs - Action executor with timeouts
- src/client/tui/events.rs - Async event handler
- src/client/tui/ui.rs - UI rendering
feat: refactor xinet.create to xinet.set with replacement pattern
Some checks failed
Build Linux / build-linux (linux-amd64, x86_64-unknown-linux-gnu) (push) Failing after 54s
Details
876e12dce8 
- Rename RPC method from xinet.create to xinet.set
- Implement replacement logic in XinetManager.register()
  * Stops existing proxy before creating new one
  * Cleans up old proxy resources (sockets, tasks)
  * Logs replacement operations
  * Matches service.set() pattern
- Update API specifications (openrpc.json, zinit.oschema)
- Rename client methods: xinet_register() -> xinet_set()
  * Update async_client.rs
  * Update sync client.rs
  * Update CLI command handler
- Remove dead code: make_system_config() test helper
- Update README with comprehensive xinet documentation
  * Added xinet CLI commands reference
  * Added use cases and examples
  * Added PostgreSQL socket activation example
  * Added multi-address proxy example
  * Documented all xinet features

Testing:
- All 131 unit tests passing
- All 3 doc tests passing
- Build succeeds (debug and release)
- No compiler warnings

Audit completed:
- SDK error handling: A+ grade
- Server error handling: A+ grade
- Zero silent failures in critical paths
- All error patterns validated
- Production-ready code quality
The TUI code calls client.remove() but AsyncZinitClient only had delete().
Both methods are server-side aliases, but the sync client has both.
Add remove() to match the sync client API.
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin development_stability:development_stability
git switch development_stability

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development
git merge --no-ff development_stability
git switch development_stability
git rebase development
git switch development
git merge --ff-only development_stability
git switch development_stability
git rebase development
git switch development
git merge --no-ff development_stability
git switch development
git merge --squash development_stability
git switch development
git merge --ff-only development_stability
git switch development
git merge development_stability
git push origin development
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
geomind_code/zinit!6
No description provided.