DM shows raw public key instead of contact name #54

New issue

Closed

opened 2026-04-19 08:25:35 +00:00 by zaelgohary · 1 comment

zaelgohary commented

2026-04-19 08:25:35 +00:00

Member

Server-side DMs are created with conversation.name = format!("DM with {}", participant_public_key). The messaging archipelago rendered that stored string literally in both the chat list and the chat detail header, so the UI showed raw keys like 'DM with fulltest123key456' where the contact's friendly name was expected.

Fix: add participant_keys: Vec<String> to ChatPreviewData; expose a pure resolve_chat_display_name(raw_name, is_group, participant_keys, own_user_key, contacts) helper in the service layer; load contacts unconditionally on archipelago mount; resolve the non-self participant's contact name at render time and in the chat detail fetch. Groups keep the stored name unchanged; unknown participants fall back to the raw name.

Server-side DMs are created with `conversation.name = format!("DM with {}", participant_public_key)`. The messaging archipelago rendered that stored string literally in both the chat list and the chat detail header, so the UI showed raw keys like `'DM with fulltest123key456'` where the contact's friendly name was expected. **Fix**: add `participant_keys: Vec<String>` to `ChatPreviewData`; expose a pure `resolve_chat_display_name(raw_name, is_group, participant_keys, own_user_key, contacts)` helper in the service layer; load contacts unconditionally on archipelago mount; resolve the non-self participant's contact name at render time and in the chat detail fetch. Groups keep the stored name unchanged; unknown participants fall back to the raw name.

~~zaelgohary referenced this issue 2026-04-19 08:29:02 +00:00~~

messaging: fix timestamps, UX, DM names, perf #56

zaelgohary referenced this issue from a commit

2026-04-19 08:29:02 +00:00

messaging: fix timestamps, optimistic send, auto-scroll, DM names, and perf

zaelgohary referenced this issue

2026-04-19 08:31:56 +00:00

messaging: fix timestamps, UX, DM names, perf #56

zaelgohary changed title from ~~bug: DM name shows 'DM with <public_key>' instead of the contact's name~~ to DM shows raw public key instead of contact name

2026-04-19 08:32:20 +00:00

zaelgohary referenced this issue from a commit

2026-04-19 09:26:04 +00:00

tests: end-to-end messaging regression

~~zaelgohary referenced this issue from lhumina_code/hero_os 2026-04-19 09:26:23 +00:00~~

tests: end-to-end messaging regression #71

zaelgohary referenced this issue from a commit

2026-04-19 09:43:36 +00:00

tests: end-to-end messaging regression

zaelgohary commented

2026-04-19 09:55:55 +00:00

Author