message sender shows "Message in <sid>" instead of contact name #58

New issue

Closed

opened 2026-04-19 10:33:07 +00:00 by zaelgohary · 0 comments

zaelgohary commented

2026-04-19 10:33:07 +00:00

Member

Other-user message bubbles show Message in <conv_sid> (the server's internal ChatMessage.name) as the sender label, even for senders who are in the contact list.

Root cause: services::chatmessage_to_messagedata sets sender_name: msg.name.clone() for non-own messages, but msg.name is a technical identifier (format!("Message in {}", conversation_sid) on the server). The real identity is msg.sender_public_key — that should be looked up against contacts, like we already do for DM chat names (#54).

Fix: resolve sender_public_key against contacts, fall back to the raw key when no match.

Other-user message bubbles show `Message in <conv_sid>` (the server's internal `ChatMessage.name`) as the sender label, even for senders who are in the contact list. Root cause: `services::chatmessage_to_messagedata` sets `sender_name: msg.name.clone()` for non-own messages, but `msg.name` is a technical identifier (`format!("Message in {}", conversation_sid)` on the server). The real identity is `msg.sender_public_key` — that should be looked up against contacts, like we already do for DM chat names (#54). Fix: resolve `sender_public_key` against contacts, fall back to the raw key when no match.