fix(tasks): theme-neutral row background + borders #129

Merged
zaelgohary merged 1 commit from development_fix_tasks_theme_and_priority into development 2026-04-22 09:49:28 +00:00
Member

Summary

Task rows rendered with a hard-coded dark #2b3035 background and a white-alpha border on the non-completed branch. Under light theme the rows looked like opaque dark panels and the delete/edit IconButtons were invisible against them.

Closes #117

Changes

  • task_item.rs — theme-neutral alpha values for row bg + row/checkbox borders

Test Results

  • cargo check -p hero_archipelagos_tasks: pass
  • cargo clippy -p hero_archipelagos_tasks -- -D warnings: pass
  • cargo fmt --check -p hero_archipelagos_tasks: pass
  • dx build --package hero_os_app --web --features web: pass, deployed to the shared test instance
  • Playwright: tasks list view in light theme renders with readable rows and visible action buttons (see screenshots/tasks_list_view.png)

Manual verification

  • Switch Hero OS to light theme, open Tasks — rows show a subtle light background, edit/delete icons are clearly visible
  • Switch to dark theme — rows still readable, no visual regression
  • Mark a task complete — the green-tinted completed style still applies
## Summary Task rows rendered with a hard-coded dark `#2b3035` background and a white-alpha border on the non-completed branch. Under light theme the rows looked like opaque dark panels and the delete/edit IconButtons were invisible against them. ## Related Issue Closes #117 ## Changes - `task_item.rs` — theme-neutral alpha values for row bg + row/checkbox borders ## Test Results - `cargo check -p hero_archipelagos_tasks`: pass - `cargo clippy -p hero_archipelagos_tasks -- -D warnings`: pass - `cargo fmt --check -p hero_archipelagos_tasks`: pass - `dx build --package hero_os_app --web --features web`: pass, deployed to the shared test instance - Playwright: tasks list view in light theme renders with readable rows and visible action buttons (see `screenshots/tasks_list_view.png`) ## Manual verification - [ ] Switch Hero OS to light theme, open Tasks — rows show a subtle light background, edit/delete icons are clearly visible - [ ] Switch to dark theme — rows still readable, no visual regression - [ ] Mark a task complete — the green-tinted completed style still applies
fix(tasks): theme-neutral row background + borders
All checks were successful
Build and Test / build (pull_request) Successful in 6m9s
43d00b5251
Task rows used a literal dark `#2b3035` background and a literal
white-alpha border on the non-completed branch. Under light theme the
rows rendered as opaque dark panels and the delete/edit IconButtons
disappeared against them.

Switch both to theme-neutral alpha values that work on both themes;
bump the checkbox border alpha to stay visible on light.
zaelgohary merged commit 51da231138 into development 2026-04-22 09:49:28 +00:00
zaelgohary deleted branch development_fix_tasks_theme_and_priority 2026-04-22 09:49:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_archipelagos!129
No description provided.