feat(office_views): show progress while uploading #167

Merged

zaelgohary merged 1 commit from development_feat_upload_progress into development

2026-04-27 14:18:08 +00:00

zaelgohary commented

2026-04-27 14:11:38 +00:00

Member

Summary

Office FileListView upload had no in-flight feedback — clicks went silent until either the listing refreshed (success) or the red error banner appeared. For larger files the silent gap could be many seconds, and accidental double-clicks queued multiple uploads with no indication.

Adds an uploading_name signal that's set when the upload coroutine picks up a file and cleared when the upload finishes. Renders an italic "Uploading {filename}…" chip in the toolbar and disables the Upload button while a transfer is in flight.

Closes #166

Changes

archipelagos/embed/office/src/views.rs — uploading_name signal, button disable, toolbar chip

Test Results

cargo check --workspace ✅
Local dx build --release succeeds; bundle smaller than baseline (8.6 MB raw)
Playwright office_editor_real 4/4 ✅

Manual verification

Upload of a real PDF visibly disables the button, shows "Uploading …", clears on success/error.
Listing refreshes after success as before.

Notes

This change is gated on the merge of:

hero_office #20 (body limit) — without it, real-world upload sizes still 413
hero_foundry #19 (URL-decode) — without it, filenames with spaces store as %20-encoded
hero_router #61 (percent-encoding) — without it, file fetch GETs panic the router worker

## Summary Office FileListView upload had no in-flight feedback — clicks went silent until either the listing refreshed (success) or the red error banner appeared. For larger files the silent gap could be many seconds, and accidental double-clicks queued multiple uploads with no indication. Adds an `uploading_name` signal that's set when the upload coroutine picks up a file and cleared when the upload finishes. Renders an italic "Uploading {filename}…" chip in the toolbar and disables the Upload button while a transfer is in flight. ## Related Issue Closes #166 ## Changes - `archipelagos/embed/office/src/views.rs` — `uploading_name` signal, button disable, toolbar chip ## Test Results - `cargo check --workspace` ✅ - Local `dx build --release` succeeds; bundle smaller than baseline (8.6 MB raw) - Playwright `office_editor_real` 4/4 ✅ ## Manual verification - Upload of a real PDF visibly disables the button, shows "Uploading <name>…", clears on success/error. - Listing refreshes after success as before. ## Notes This change is gated on the merge of: - hero_office #20 (body limit) — without it, real-world upload sizes still 413 - hero_foundry #19 (URL-decode) — without it, filenames with spaces store as `%20`-encoded - hero_router #61 (percent-encoding) — without it, file fetch GETs panic the router worker

zaelgohary added 1 commit

2026-04-27 14:11:38 +00:00