chore(lint): clear fmt + clippy unused_mut on archipelagos_server #177

Merged

mik-tf merged 2 commits from development_mik into development

2026-04-28 01:02:46 +00:00

mik-tf commented

2026-04-28 00:50:44 +00:00

Owner

Two mechanical fixes for the rustfmt + clippy steps that were silently failing on development run #387 (continue-on-error: true).

fmt

archipelagos/system/contexts/src/views/create_form.rs:55 — let can_submit = … chain folded onto a single line per rustfmt.

clippy `-D unused_mut`

server/src/main.rs — 9 let mut x = use_signal(|| …) bindings dropped the mut (lines 614, 615, 618-622, 1150, 2501). Dioxus 0.7 Signal<T> mutates through &self via the reactive runtime — no binding-level mut needed.

Behaviour unchanged. Just clearing the silent CI red.

Signed-off-by: mik-tf

Two mechanical fixes for the rustfmt + clippy steps that were silently failing on `development` run #387 (`continue-on-error: true`). ## fmt * `archipelagos/system/contexts/src/views/create_form.rs:55` — `let can_submit = …` chain folded onto a single line per rustfmt. ## clippy `-D unused_mut` * `server/src/main.rs` — 9 `let mut x = use_signal(|| …)` bindings dropped the `mut` (lines 614, 615, 618-622, 1150, 2501). Dioxus 0.7 `Signal<T>` mutates through `&self` via the reactive runtime — no binding-level `mut` needed. Behaviour unchanged. Just clearing the silent CI red. Signed-off-by: mik-tf

mik-tf added 1 commit

2026-04-28 00:50:44 +00:00

chore(lint): clear fmt + clippy unused_mut on archipelagos_server

Build and Test / build (pull_request) Failing after 0s

Details

5ae9aac28d

CI on `development` (run #387) passes the build but flags two checks
via `continue-on-error`: rustfmt and clippy:

* `archipelagos/system/contexts/src/views/create_form.rs` — rustfmt
  wanted the `let can_submit = …` chain on a single line.

* `server/src/main.rs` — clippy `-D unused_mut` on 9 `let mut x =
  use_signal(|| …)` bindings (lines 614, 615, 618-622, 1150, 2501).
  Dioxus 0.7 `Signal<T>` has interior mutability via the reactive
  runtime, so `.set(...)` / `.write(...)` work through `&self` — no
  `mut` on the binding required.

Both are mechanical fixes; behaviour unchanged. The remaining
`continue-on-error` step (clippy) will turn fully clean once these
two land.

Signed-off-by: mik-tf

mik-tf added 1 commit

2026-04-28 00:51:37 +00:00

ci: re-trigger after runner Docker pool exhaustion (run #388 )

Build and Test / build (pull_request) Successful in 5m18s

Details

5ac35e3fd8