fix(office): percent-encode filename + context in editor_url #178

Merged

zaelgohary merged 1 commit from development_fix_office_editor_url_encoding into development

2026-04-28 07:14:06 +00:00

zaelgohary commented

2026-04-28 07:07:28 +00:00

Member

Summary

Non-ASCII filenames (Arabic, CJK) and names with spaces broke the OnlyOffice iframe src because editor_url() interpolated the raw filename and context. Re-encoded both via a small in-crate urlenc helper (RFC 3986 unreserved set, byte-iterating UTF-8).

Changes

archipelagos/embed/office/src/service.rs — percent-encode filename + context in editor_url; add urlenc helper.

Test Results

playwright office_crud 26/26 + office_editor_real 4/4 green; Arabic round-trip test exercises the fix.

Manual verification

Opened .docx with Arabic + space-in-name in the browser via the deployed v3 build — iframe loads.

## Summary Non-ASCII filenames (Arabic, CJK) and names with spaces broke the OnlyOffice iframe `src` because `editor_url()` interpolated the raw filename and context. Re-encoded both via a small in-crate `urlenc` helper (RFC 3986 unreserved set, byte-iterating UTF-8). ## Changes - `archipelagos/embed/office/src/service.rs` — percent-encode filename + context in `editor_url`; add `urlenc` helper. ## Test Results playwright office_crud 26/26 + office_editor_real 4/4 green; Arabic round-trip test exercises the fix. ## Manual verification Opened `.docx` with Arabic + space-in-name in the browser via the deployed v3 build — iframe loads.