fix: clean up clippy suppressions and restore WASM crate coverage #27

Open

mik-tf wants to merge 5 commits from development_fix_tech_debt into development

pull from: development_fix_tech_debt

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:development_ci_working

lhumina_code:development_pdf_preview

Conversation 0 Commits 5 Files changed 47 +413 -222

mik-tf commented 2026-02-24 03:56:23 +00:00

Owner

Copy link

Clean up tech debt from CI fix PR #25.

Changes

• Refactor upload_and_create_song to accept a CreateSongRequest struct instead of 8 positional arguments
• Delete unused Role type alias, Bot import, and AVAILABLE_MODELS constant from intelligence crate
• Add platform-specific create_client() wrappers to os_widgets for wasm32/native compatibility
• Re-include os_widgets and os_components in CI WASM check

Testing

• make ci-docker passes locally
• Native and WASM cargo check pass
• All unit tests pass

Closes #26

Clean up tech debt from CI fix PR #25. ## Changes - Refactor `upload_and_create_song` to accept a `CreateSongRequest` struct instead of 8 positional arguments - Delete unused `Role` type alias, `Bot` import, and `AVAILABLE_MODELS` constant from intelligence crate - Add platform-specific `create_client()` wrappers to os_widgets for wasm32/native compatibility - Re-include os_widgets and os_components in CI WASM check ## Testing - `make ci-docker` passes locally - Native and WASM cargo check pass - All unit tests pass Closes #26

mik-tf added 5 commits 2026-02-24 03:56:23 +00:00

fix: make CI build workflow pass 100% on all workspace crates ... 4d58772fbb

- Run cargo fmt --all across workspace (25+ files with formatting drift)
- Fix build.rs to run rustfmt on generated island_content.rs
- Update WASM check in build.yaml: use --workspace --exclude instead of
  stale hardcoded crate list (12 → all island crates automatically)
- Align Makefile targets with CI workflow:
  - test: cargo test --workspace --lib (matches CI, skips broken doc tests)
  - fmt/fmt-check: use --all flag (matches CI cargo fmt --all)
  - lint: exclude livekit_bridge (matches CI clippy exclusion)
- Fix ci-docker.sh: clean up root-owned .cargo/config.toml between runs
  to prevent duplicate [patch] entries
- Fix clippy warnings: remove unused imports (IslandContext in kanban,
  sprints, stories), remove dead constant (BTN_DISABLED_STYLE), fix
  push_str single-char, allow dead_code on public icon constants
- Apply cargo clippy --fix for clone-on-copy, redundant closures, etc.

Verified with make ci-docker (100% fidelity with Forgejo runner).

Closes #24

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: resolve WASM compilation errors from CI run ... 4bca09a732

- Fix `_view` → `view` in theme island's dispatch_view_change (E0425)
- Exclude os_widgets and os_components from WASM check (examples depend
  on BaseClient API that drifts with patched hero_osis_sdk)
- Remove uniffi-bindgen from exclude list (not in workspace)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: resolve all remaining clippy warnings for clean CI ... 95ca2b6851

- editor: allow clippy::should_implement_trait on from_str method
- intelligence: allow dead_code on Role alias and AVAILABLE_MODELS const
- business: fix let_underscore_future (use named binding for use_resource)
- business: fix redundant_pattern_matching (use .is_ok() instead of
  if let Ok(_))
- business: fix format_in_format_args (fold nested format! calls)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: suppress too_many_arguments clippy warning in songs crate ... 0e213da581

The upload_and_create_song function takes 8 parameters (1 over clippy's
default max of 7). Adding an allow attribute for this specific case.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: clean up clippy suppressions and restore WASM crate coverage ... cc53c44e92

- Refactor upload_and_create_song to use CreateSongRequest struct,
  removing the too_many_arguments suppression
- Delete unused Role type alias and AVAILABLE_MODELS constant from
  intelligence crate role_editor
- Add platform-specific create_client() wrappers to os_widgets so
  BaseClient::new() compiles on both wasm32 and native targets
- Re-include os_widgets and os_components in the CI WASM check

Closes #26

mik-tf changed title from WIP: fix: clean up clippy suppressions and restore WASM crate coverage to fix: clean up clippy suppressions and restore WASM crate coverage 2026-02-24 04:06:41 +00:00

All checks were successful

Hide all checks

Build and Test / build (pull_request) Successful in 4m51s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_fix_tech_debt:development_fix_tech_debt

git switch development_fix_tech_debt

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff development_fix_tech_debt

git switch development_fix_tech_debt

git rebase development

git switch development

git merge --ff-only development_fix_tech_debt

git switch development_fix_tech_debt

git rebase development

git switch development

git merge --no-ff development_fix_tech_debt

git switch development

git merge --squash development_fix_tech_debt

git switch development

git merge --ff-only development_fix_tech_debt

git switch development

git merge development_fix_tech_debt

git push origin development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_archipelagos!27

No description provided.