lhumina_code/hero_archipelagos
22
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

Fix books island metadata and standalone registration #33

Closed
mik-tf wants to merge 0 commits from development_fix_books_island_metadata into development
pull from: development_fix_books_island_metadata
merge into: lhumina_code:development
Conversation 1 Commits - Files changed - +107 -53
mik-tf commented 2026-02-26 23:46:49 +00:00
Owner
Copy link

Summary

  • Add [package.metadata.island] so build_standalone.sh discovers the books island
  • Port register_custom_element to the new 5-argument API (connected/disconnected/attribute_changed callbacks)
  • Add wasm-opt = false and proper web feature gating matching other embed islands

Test

cd archipelagos/embed/books
wasm-pack build --target web --features standalone --no-default-features

Closes #32

## Summary - Add `[package.metadata.island]` so `build_standalone.sh` discovers the books island - Port `register_custom_element` to the new 5-argument API (connected/disconnected/attribute_changed callbacks) - Add `wasm-opt = false` and proper web feature gating matching other embed islands ## Test ```bash cd archipelagos/embed/books wasm-pack build --target web --features standalone --no-default-features ``` Closes #32
fix: add island metadata and update register API for books island
Some checks failed
Build and Test / build (pull_request) Failing after 6s
Details
b2903dfe83 
Add [package.metadata.island] so build_standalone.sh discovers the
books island. Port register_custom_element call to the new 5-argument
API (connected/disconnected/attribute_changed callbacks). Add wasm-opt
= false and proper web feature gating.

Closes #32
mik-tf changed title from WIP: Fix books island metadata and standalone registration to Fix books island metadata and standalone registration 2026-02-26 23:57:52 +00:00
mik-tf commented 2026-03-02 15:22:17 +00:00
Author
Owner
Copy link

Consolidated into PR #35 (development_consolidated) which merges all 7 open PRs plus the books island WASM fix. Closing this PR — changes are included in the consolidated branch.

Consolidated into PR #35 (development_consolidated) which merges all 7 open PRs plus the books island WASM fix. Closing this PR — changes are included in the consolidated branch.
mik-tf closed this pull request 2026-03-02 15:22:18 +00:00
Some checks failed
Build and Test / build (pull_request) Failing after 6s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_archipelagos!33
No description provided.