ui(admin): drop explicit rpc-url on logs viewer (hero_proc default kicks in) #23

Merged

mik-tf merged 1 commit from development_mik into development

2026-05-23 16:14:01 +00:00

mik-tf commented

2026-05-23 16:08:15 +00:00

Owner

Follow-up to lhumina_code/hero_website_framework#9. The web component now defaults its logs endpoint to /hero_proc/rpc, so the explicit override on this template was redundant and aimed the component at the wrong daemon. Dropping it lets the new default kick in.

Test plan

lab build --release --install --workspace clean (4/4 binaries)
strings hero_assistance_admin | grep logs-rpc-url returns 5
After restart, served /static/shared/js/logs-viewer.js contains the new precedence chain
Rendered admin / no longer emits rpc-url on <hero-logs-viewer>
Curl /hero_proc/rpc through hero_router returns log rows

Out-of-scope follow-up

Live verify also surfaced a pre-existing schema mismatch between hero_proc.logs.filter (returns line / src / stream / timestamp_ms) and what <hero-logs-viewer> renders against (ts / content / src / loglevel / error / tags). Will be filed as a new hero_website_framework issue after this lands.

Follow-up to https://forge.ourworld.tf/lhumina_code/hero_website_framework/pulls/9. The web component now defaults its logs endpoint to `/hero_proc/rpc`, so the explicit override on this template was redundant and aimed the component at the wrong daemon. Dropping it lets the new default kick in. ## Test plan - [x] `lab build --release --install --workspace` clean (4/4 binaries) - [x] `strings hero_assistance_admin | grep logs-rpc-url` returns 5 - [x] After restart, served `/static/shared/js/logs-viewer.js` contains the new precedence chain - [x] Rendered admin `/` no longer emits `rpc-url` on `<hero-logs-viewer>` - [x] Curl `/hero_proc/rpc` through hero_router returns log rows ## Out-of-scope follow-up Live verify also surfaced a pre-existing schema mismatch between `hero_proc.logs.filter` (returns `line` / `src` / `stream` / `timestamp_ms`) and what `<hero-logs-viewer>` renders against (`ts` / `content` / `src` / `loglevel` / `error` / `tags`). Will be filed as a new hero_website_framework issue after this lands.

mik-tf added 1 commit

2026-05-23 16:08:15 +00:00

ui(admin): drop explicit rpc-url on logs viewer (hero_proc default kicks in) 32f809a811

After hero_website_framework@f7540ae5 added the logs-rpc-url attribute on
<hero-logs-viewer> defaulting to /hero_proc/rpc, the admin template's explicit
rpc-url override was redundant and actively wrong: it aimed the component at
the dashboard's own /rpc (hero_assistance_admin) which proxies to _server,
which does not implement logs.filter. Dropping the attribute lets the new
default kick in so the Logs tab posts to /hero_proc/rpc and shows supervisor
logs as intended.

Verified live: rebuilt + restarted; curl on admin.sock /static/shared/js/
logs-viewer.js shows the new precedence chain; rendered index.html no longer
emits the rpc-url attribute; manual curl of /hero_proc/rpc through hero_router
returns log rows.

Follow-up gap (out of scope for this fix, will be filed as a new issue):
the hero_proc logs.filter response schema (line / src / stream / timestamp_ms)
does not match what <hero-logs-viewer> renders against (ts / content / src /
loglevel / error / tags). Only src lines up. Until the component or hero_proc
is reshaped to match, the Logs tab will show the source column populated but
empty timestamps + empty content. This is a pre-existing component-schema
mismatch, not a regression from this PR.

Signed-by: mik-tf <mik-tf@noreply.invalid>