ci: call cargo_env after sourcing build_lib.sh so cargo is on PATH #1

Open

mik-tf wants to merge 8 commits from development_mik into development

pull from: development_mik

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:main

Conversation 0 Commits 8 Files changed 1 +26 -2

mik-tf commented 2026-04-28 01:13:04 +00:00

Owner

Copy link

Fixes the silent CI red on development: every run bails immediately at the first make call with cargo: No such file or directory. The shell exec context for each step does not auto-source ~/.cargo/env. Same fix already proven on hero_archipelagos and other green repos.

No behavioural change on hosts where cargo is already on PATH.

Signed-off-by: mik-tf

Fixes the silent CI red on `development`: every run bails immediately at the first `make` call with `cargo: No such file or directory`. The shell exec context for each step does not auto-source `~/.cargo/env`. Same fix already proven on hero_archipelagos and other green repos. No behavioural change on hosts where cargo is already on PATH. Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 01:13:04 +00:00

ci: call cargo_env after sourcing build_lib.sh so cargo is on PATH ... 0aee86bfff

CI on `development` was failing every run with
`make: cargo: No such file or directory`. Sourcing build_lib.sh only
defines its functions — it does NOT auto-prepend cargo/rustup to
PATH. The required helper `cargo_env` is defined right there in
build_lib.sh; the workflow just wasn't calling it after the source.

Same minimal fix as the working-CI repos. No behavioural change
on hosts where cargo is already on PATH (cargo_env is idempotent).

Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 01:39:32 +00:00

ci: retrigger after FORGEJO_TOKEN org-level secret added ... 73ee53c26d

Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 01:42:03 +00:00

ci: explicitly pass FORGEJO_TOKEN to actions/checkout ... b4e363120e

Default $GITHUB_TOKEN is not auto-injected for this repo's runner;
PR checkout was failing with 'could not read Username for
forge.ourworld.tf'. Wiring the org-level FORGEJO_TOKEN secret
through actions/checkout's 'with: token:' input makes auth work
for both push and pull_request triggers.

Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 02:40:19 +00:00

ci: retrigger after FORGEJO_TOKEN secret added at repo level ... 19d49399e6

Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 02:41:32 +00:00

ci: temporary debug step to verify FORGEJO_TOKEN secret reaches the workflow ... 53f91e3b3c

Will be removed once we confirm the secret is or isn't propagating.

Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 02:42:38 +00:00

ci: test manual git clone + API call with the secret ... 458a6dfaf7

Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 02:43:30 +00:00

ci: replace actions/checkout@v4 with manual clone (Forgejo auth bug) ... 6c53c4d99f

actions/checkout@v4 has a bug against Forgejo: even when the
FORGEJO_TOKEN secret reaches the workflow with the correct value
(verified TOKEN length 40, manual git clone with the same token
succeeds), the action fails at git fetch with 'could not read
Username for forge.ourworld.tf'. The action's git extraheader auth
mechanism doesn't survive whatever Forgejo's runner does to the
fetch URL.

Workaround: clone manually with the token embedded in the URL.
Matches the auth shape we already use for cross-repo dep clones.

Will switch back to actions/checkout@v4 when the upstream action
is fixed against Forgejo.

Signed-off-by: mik-tf

mik-tf added 1 commit 2026-04-28 03:39:20 +00:00

ci: clone PR source branch (was cloning default branch instead) ... 9062001864

Same bug fixed in hero_editor: `git clone --depth 1` without
--branch defaults to the repo's default branch (development), and
the SHA-based fallback didn't fire because Forgejo's runner appears
to leave \${{ github.event.pull_request.head.sha }} empty. So CI was
silently running against `development`'s HEAD instead of the
development_mik branch tip.

Switch to --branch \$GITHUB_HEAD_REF / \$GITHUB_REF_NAME — same shape
hero_voice and the updated hero_skills/tools/docs/forgejo_ci.md §2
recommend.

Signed-off-by: mik-tf

Some checks failed

Hide all checks

Build and Test / build (pull_request) Failing after 24s

Details

Build and Test / build (push) Failing after 27s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_mik:development_mik

git switch development_mik

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff development_mik

git switch development_mik

git rebase development

git switch development

git merge --ff-only development_mik

git switch development_mik

git rebase development

git switch development

git merge --no-ff development_mik

git switch development

git merge --squash development_mik

git switch development

git merge --ff-only development_mik

git switch development

git merge development_mik

git push origin development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

prio_critical

  

prio_low

  

type_bug

  

type_contact

  

type_issue

  

type_lead

  

type_question

  

type_story

  

type_task

No labels

prio_critical

prio_low

type_bug

type_contact

type_issue

type_lead

type_question

type_story

type_task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_cluster!1

No description provided.