fix(deps): unblock workspace build on Linux #65

Merged

sameh-farouk merged 1 commit from unblock_main_build into main

2026-06-03 02:11:44 +00:00

sameh-farouk commented

2026-06-03 02:11:43 +00:00

Member

Scope

main-only minimal fix. Removes the broken [patch."hero_proxy.git"] hardcoded macOS path that prevented main from building on Linux. Deliberately does NOT bring development's CI workflow changes (auth fix + RUST_MIN_STACK) to main — those live on development per the "main = stable snapshot" branching intent.

Why

Cargo workspace had:

[patch."https://forge.ourworld.tf/lhumina_code/hero_proxy.git"]
hero_proxy_sdk = { path = "/Volumes/T7/hero/code/hero_proxy/crates/hero_proxy_sdk" }

That path only exists on the developer's macOS box. cargo check failed on Linux (and CI) with:

error: failed to load source for dependency `hero_proxy_sdk`
Caused by:
  unable to update /Volumes/T7/hero/code/hero_proxy/crates/hero_proxy_sdk

The crate-level Cargo.toml in hero_collab_server already declares hero_proxy_sdk via its git URL, so removing the override resolves naturally.

This patch was previously removed in 9c4d84a; regressed since.

Verification

cargo check --workspace passes locally (1.52s on a warm cache; only existing unused-mut warnings in hero_collab_app, no errors).
Diff is exactly 4 lines: 3-line block removal in Cargo.toml + 1-line source = pin in Cargo.lock so the lockfile is deterministic.

Merge style

Per branching policy: Create merge commit (not squash) — same shape as hero_planner PR #7.

Not in this PR (intentional)

.forgejo/workflows/lab-publish.yaml auth + RUST_MIN_STACK changes — those are dev-loop infrastructure that's already on development (hero_collab PR #64). main stays on its current CI workflow snapshot.

## Scope **main-only minimal fix.** Removes the broken `[patch."hero_proxy.git"]` hardcoded macOS path that prevented main from building on Linux. Deliberately does NOT bring development's CI workflow changes (auth fix + RUST_MIN_STACK) to main — those live on development per the "main = stable snapshot" branching intent. ## Why Cargo workspace had: ```toml [patch."https://forge.ourworld.tf/lhumina_code/hero_proxy.git"] hero_proxy_sdk = { path = "/Volumes/T7/hero/code/hero_proxy/crates/hero_proxy_sdk" } ``` That path only exists on the developer's macOS box. `cargo check` failed on Linux (and CI) with: ``` error: failed to load source for dependency `hero_proxy_sdk` Caused by: unable to update /Volumes/T7/hero/code/hero_proxy/crates/hero_proxy_sdk ``` The crate-level Cargo.toml in `hero_collab_server` already declares `hero_proxy_sdk` via its git URL, so removing the override resolves naturally. This patch was previously removed in `9c4d84a`; regressed since. ## Verification - `cargo check --workspace` passes locally (1.52s on a warm cache; only existing unused-mut warnings in `hero_collab_app`, no errors). - Diff is exactly 4 lines: 3-line block removal in `Cargo.toml` + 1-line `source =` pin in `Cargo.lock` so the lockfile is deterministic. ## Merge style Per branching policy: **Create merge commit** (not squash) — same shape as `hero_planner` PR #7. ## Not in this PR (intentional) - `.forgejo/workflows/lab-publish.yaml` auth + `RUST_MIN_STACK` changes — those are dev-loop infrastructure that's already on `development` (hero_collab PR #64). main stays on its current CI workflow snapshot.

sameh-farouk added 1 commit

2026-06-03 02:11:43 +00:00

fix(deps): unblock workspace build on Linux 788df49ad6

Remove stale [patch."hero_proxy.git"] hardcoded macOS path
(/Volumes/T7/hero/code/hero_proxy/crates/hero_proxy_sdk) — broke
cargo workspace resolution anywhere off macOS. The crate-level
Cargo.toml in hero_collab_server already declares hero_proxy_sdk
via its git URL, so removing the override resolves naturally.

Cargo.lock updated with the corresponding source pin
(git+...hero_proxy.git?branch=development#68c1f70c) so the
lockfile is deterministic and cargo does not silently re-resolve
upstream on the next fetch.

This patch was previously removed in 9c4d84a; regressed since.

Scope deliberately limited to the build-unblock fix — CI workflow
changes (auth + RUST_MIN_STACK) live on development and are not
brought to main per the "main = stable snapshot" branching intent.

Verified: cargo check --workspace passes locally (only existing
unused-mut warnings in hero_collab_app, no errors).