fix(web): derive rpc-path correctly for /web and /admin mounts (cherry-pick) #68

Merged
sameh-farouk merged 1 commit from fix_rpc_path_main into main 2026-06-03 15:35:06 +00:00
Member

Cherry-pick of #67 (squash d780f4e) from development to main.

Same bug present identically on main: rpc_path_from_base only stripped /ui, so after the ui.sockweb.sock rename the /web mount produced /<service>/web/rpc/rpc (404), breaking canvas RPC and triggering a spurious "Who are you?" identity prompt. Now strips /ui, /web, or /admin.

Verified on development branch (meta now /hero_collab/rpc/rpc, RPC returns 200, canvas loads with identity). Code path identical on main.

Cherry-pick of #67 (squash `d780f4e`) from development to main. Same bug present identically on main: `rpc_path_from_base` only stripped `/ui`, so after the `ui.sock` → `web.sock` rename the `/web` mount produced `/<service>/web/rpc/rpc` (404), breaking canvas RPC and triggering a spurious "Who are you?" identity prompt. Now strips `/ui`, `/web`, or `/admin`. Verified on development branch (meta now `/hero_collab/rpc/rpc`, RPC returns 200, canvas loads with identity). Code path identical on main.
rpc_path_from_base only stripped /ui; after ui.sock->web.sock rename the /web mount produced /<svc>/web/rpc/rpc (404), breaking canvas RPC + causing a spurious identity prompt. Now strips /ui, /web, or /admin.
sameh-farouk deleted branch fix_rpc_path_main 2026-06-03 15:35:13 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_collab!68
No description provided.