lhumina_code/hero_collab
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 3 Packages Wiki Activity Actions

fix(cli): health-check collab_web over its Unix socket, not TCP (cherry-pick) #70

Merged
sameh-farouk merged 1 commit from healthcheck_main into main 2026-06-03 16:05:21 +00:00
Conversation 0 Commits 1 Files changed 1 +9 -1
sameh-farouk commented 2026-06-03 16:05:20 +00:00
Member
Copy link

Cherry-pick of #69 (squash 8e3ad9a) from development to main.

Same bug on main: collab_web's hero_proc health check used http://localhost/health (parsed as TCP, always refused) instead of http+unix://web.sock, so hero_proc killed the healthy daemon every ~14s and restart-looped it to failed. Now uses the http-over-UDS form.

Verified on development: collab_web stays running attempt=0 under hero_proc for 40s+. Code path identical on main.

Cherry-pick of #69 (squash `8e3ad9a`) from development to main. Same bug on main: collab_web's hero_proc health check used `http://localhost/health` (parsed as TCP, always refused) instead of `http+unix://web.sock`, so hero_proc killed the healthy daemon every ~14s and restart-looped it to `failed`. Now uses the http-over-UDS form. Verified on development: collab_web stays `running attempt=0` under hero_proc for 40s+. Code path identical on main.
collab_web health check used http://localhost/health (TCP, always refused) instead of http+unix://web.sock, so hero_proc killed the healthy daemon every ~14s. Now uses the http+unix UDS form. Verified: stays running attempt=0 for 40s+.
sameh-farouk deleted branch healthcheck_main 2026-06-03 16:05:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_collab!70
No description provided.