lhumina_code/hero_compute
0
0
Fork 0
Code Issues 6 Pull requests Projects Releases 9 Packages Wiki Activity Actions 1

fix: honor CARGO_TARGET_DIR in Makefile #104

Merged
omarz merged 1 commit from development_fix_makefile_cargo_target_dir into development 2026-04-29 13:33:31 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -1
omarz commented 2026-04-29 13:33:16 +00:00
Member
Copy link

The Makefile hardcoded RELEASE_DIR to target/, so users who export
CARGO_TARGET_DIR (a shared build cache, common in the Hero env) saw
make build fail with "cp: cannot stat target/.../hero_compute" even
though cargo had built the binaries successfully into the configured
target dir.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

The Makefile hardcoded RELEASE_DIR to target/, so users who export CARGO_TARGET_DIR (a shared build cache, common in the Hero env) saw make build fail with "cp: cannot stat target/.../hero_compute" even though cargo had built the binaries successfully into the configured target dir. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix: honor CARGO_TARGET_DIR in Makefile
All checks were successful
Test / test (pull_request) Successful in 2m0s
Details
Test / test (push) Successful in 2m15s
Details
Build Linux / build-linux (linux-arm64-gnu, true, aarch64-unknown-linux-gnu) (push) Successful in 3m30s
Details
Build Linux / build-linux (linux-amd64-musl, false, x86_64-unknown-linux-musl) (push) Successful in 3m43s
Details
8830a31e12 
The Makefile hardcoded RELEASE_DIR to target/, so users who export
CARGO_TARGET_DIR (a shared build cache, common in the Hero env) saw
make build fail with "cp: cannot stat target/.../hero_compute" even
though cargo had built the binaries successfully into the configured
target dir.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
omarz merged commit 8830a31e12 into development 2026-04-29 13:33:31 +00:00
omarz deleted branch development_fix_makefile_cargo_target_dir 2026-04-29 13:33:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_compute!104
No description provided.