lhumina_code/hero_compute
0
0
Fork 0
Code Issues 6 Pull requests Projects Releases 9 Packages Wiki Activity Actions 1

fix: make my_hypervisor non-critical when binary absent #111

Closed
zaelgohary wants to merge 1 commit from development_fix_my_hypervisor_noncritical into development
pull from: development_fix_my_hypervisor_noncritical
merge into: lhumina_code:development
Conversation 1 Commits 1 Files changed 1 +1 -1
zaelgohary commented 2026-05-13 07:26:55 +00:00
Member
Copy link

Summary

The Compute dashboard fires a red 'Critical service(s) unavailable.' banner on any host without my_hypervisor on PATH. Dev machines don't host VMs and shouldn't be banner-spammed.

Related Issue

Closes #110

Changes

  • crates/hero_compute_admin/src/server.rs:681: critical flag for the my_hypervisor row is now hyp_ok || Path::new("/usr/local/bin/my_hypervisor").exists(). Dev hosts (no binary) no longer flag it as critical; production hosts (binary present but doctor failing) still do.

Test Results

Rebuilt and deployed on herodev. Pre-fix /status returned critical: true for my_hypervisor; post-fix returns critical: false. Browser-side Compute island no longer shows the red banner.

## Summary The Compute dashboard fires a red 'Critical service(s) unavailable.' banner on any host without `my_hypervisor` on PATH. Dev machines don't host VMs and shouldn't be banner-spammed. ## Related Issue Closes #110 ## Changes - `crates/hero_compute_admin/src/server.rs:681`: critical flag for the my_hypervisor row is now `hyp_ok || Path::new("/usr/local/bin/my_hypervisor").exists()`. Dev hosts (no binary) no longer flag it as critical; production hosts (binary present but doctor failing) still do. ## Test Results Rebuilt and deployed on herodev. Pre-fix `/status` returned `critical: true` for my_hypervisor; post-fix returns `critical: false`. Browser-side Compute island no longer shows the red banner.
fix: make my_hypervisor non-critical when binary absent
All checks were successful
Test / test (pull_request) Successful in 2m52s
Details
74dec5fdc2 
Closes #110
mahmoud commented 2026-05-13 08:39:39 +00:00
Owner
Copy link

Please don't merge this one, the hypervisor is the core thing to have the compute running

Please don't merge this one, the hypervisor is the core thing to have the compute running
mahmoud closed this pull request 2026-05-13 08:39:39 +00:00
mahmoud deleted branch development_fix_my_hypervisor_noncritical 2026-05-13 08:39:44 +00:00
All checks were successful
Test / test (pull_request) Successful in 2m52s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
zaelgohary
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_compute!111
No description provided.