fix(db_ui): hoist rpc() definition above component scripts #26

Merged

zaelgohary merged 2 commits from development_fix_db_rpc_scope into development

2026-04-30 11:33:33 +00:00

zaelgohary commented

2026-04-30 10:55:51 +00:00

Member

Summary

Component scripts in hero_db_ui templates (e.g. stats_card.html, database_manager.html) call rpc(...) and refreshStats() at the end of their inline script blocks, but the rpc() function was defined later in base.html — after the content block. Result: ReferenceError: rpc is not defined on every page load. Also drops the broken <link href="/hero-bootstrap-bridge.css"> from base.html and login.html.

Bootstrap-bridge link removal is part of hero_archipelagos#197 (cross-repo sweep).

Changes

Hoist rpc() and getSelectedDb() to an early <script> block in base.html.
Remove the now-duplicate definitions from the later script block.
Drop the broken /hero-bootstrap-bridge.css link from base.html and login.html.

Test Results

cargo build, smoke test in browser — refreshStats/loadDatabases now run without ReferenceError. Playwright qa_fix_verification spec passes.

## Summary Component scripts in hero_db_ui templates (e.g. stats_card.html, database_manager.html) call `rpc(...)` and `refreshStats()` at the end of their inline script blocks, but the `rpc()` function was defined later in base.html — after the content block. Result: `ReferenceError: rpc is not defined` on every page load. Also drops the broken `<link href="/hero-bootstrap-bridge.css">` from base.html and login.html. ## Related Issue Bootstrap-bridge link removal is part of hero_archipelagos#197 (cross-repo sweep). ## Changes - Hoist `rpc()` and `getSelectedDb()` to an early `<script>` block in base.html. - Remove the now-duplicate definitions from the later script block. - Drop the broken `/hero-bootstrap-bridge.css` link from base.html and login.html. ## Test Results cargo build, smoke test in browser — refreshStats/loadDatabases now run without ReferenceError. Playwright `qa_fix_verification` spec passes.