standardize: branch for ecosystem alignment #6

Merged
mik-tf merged 2 commits from development_hero_zero_standardize into development 2026-02-12 01:10:41 +00:00
Owner

Part of hero ecosystem standardization.

Changes

  • Port 3752 and buildenv.sh already compliant — no port changes needed
  • Makefile compliance: rewrote Makefile per makefile_helper skill — all logic moved to scripts/
    • Created scripts/check-deps.sh, scripts/stop-port.sh, scripts/download-models.sh, scripts/deps-install.sh
    • Every target is now 1-2 commands max (was 51 scripting violations)
    • Removed inline ONNX detection, port-killing loops, model download conditionals

Testing

All 15 hero ecosystem services Running with correct ports via hero_zero clean build. 57 unit tests pass across 6 repos, 0 failures.

Part of hero ecosystem standardization. ## Changes - Port 3752 and buildenv.sh already compliant — no port changes needed - **Makefile compliance**: rewrote Makefile per makefile_helper skill — all logic moved to `scripts/` - Created `scripts/check-deps.sh`, `scripts/stop-port.sh`, `scripts/download-models.sh`, `scripts/deps-install.sh` - Every target is now 1-2 commands max (was 51 scripting violations) - Removed inline ONNX detection, port-killing loops, model download conditionals ## Testing All 15 hero ecosystem services Running with correct ports via hero_zero clean build. 57 unit tests pass across 6 repos, 0 failures.
fix: Makefile compliance - move scripting to scripts/
All checks were successful
Test / test (push) Successful in 4m54s
Test / test (pull_request) Successful in 3m38s
56204bbd3b
- Move check-deps, stop-port, download-models, deps-install to scripts/
- Each Makefile target is now a thin wrapper
- Per makefile_helper skill
ci: restrict test triggers to PRs and push to development/main
All checks were successful
Test / test (pull_request) Successful in 2m58s
be06e2466b
Stop triggering test/build workflows on every push to every branch.
Tests now run only on:
- push to development or main (post-merge validation)
- pull_request targeting development or main (pre-merge check)
- manual workflow_dispatch

Per forge_ci skill: Standard Workflow Triggers convention.
mik-tf merged commit 0ba14f8ceb into development 2026-02-12 01:10:41 +00:00
mik-tf deleted branch development_hero_zero_standardize 2026-02-12 01:10:41 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_embedder!6
No description provided.