fix: port standardization per hero_ports registry #2

Closed

mik-tf wants to merge 6 commits from development_heroports into development

pull from: development_heroports

merge into: lhumina_code:development

lhumina_code:development

lhumina_code:main

lhumina_code:development_mik

Conversation 1 Commits 6 Files changed 4 +43 -5

mik-tf commented 2026-02-13 21:31:35 +00:00

Owner

Copy link

Summary

• Update default listen address to 127.0.0.1:3394
• Update default Redis URL to port 3378
• Include Redis auth in default connection URL
• Standardize hero_os port reference to 8880

Test plan

• hero_launcher starts on port 3394
• Connects to hero_redis on port 3378

## Summary - Update default listen address to 127.0.0.1:3394 - Update default Redis URL to port 3378 - Include Redis auth in default connection URL - Standardize hero_os port reference to 8880 ## Test plan - [ ] hero_launcher starts on port 3394 - [ ] Connects to hero_redis on port 3378

mik-tf added 1 commit 2026-02-13 21:31:35 +00:00

fix: standardize hero_os port to 8880 (88xx frontend convention) ... 2e1f7cd34e

- Replace hero_wasmos references with hero_os
- Align all port references to 8880 (was 3388/8201)
- hero_wasmos is archived, hero_os is the active frontend

mik-tf added 1 commit 2026-02-14 02:44:15 +00:00

fix: update default listen to 127.0.0.1:3394 and redis to port 3378 per hero_ports registry 94da84a8a5

mik-tf added 1 commit 2026-02-14 02:52:03 +00:00

fix: include hero_redis auth in default redis URL eae5299333

mik-tf changed title from fix: standardize hero_os port to 8880 to fix: port standardization per hero_ports registry 2026-02-14 04:44:02 +00:00

mik-tf added 1 commit 2026-02-14 14:03:24 +00:00

fix: don't pass extra CMD arg to Docker container ... 6a1ac0837a

The Dockerfile ENTRYPOINT is ["hero_zero", "run"]. Passing "hero_zero"
as CMD made the effective command "hero_zero run hero_zero", which
treated "hero_zero" as an unknown service name filter.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-14 14:38:09 +00:00

fix: disable admin UI in hero containers to avoid port conflicts ... 282c0fc062

Pass --admin-port 0 to hero_zero inside containers since --network host
shares the host's port space and the admin UI port would conflict.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf added 1 commit 2026-02-14 15:01:42 +00:00

fix: poll container status and transition from initializing to running ... 6f0ff9abbf

After launching a container, poll its status every 2s for up to 60s.
Transition to Running when container is up, or Error if it exits
or times out. Previously status was stuck on Initializing forever.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

mik-tf referenced this pull request 2026-02-19 02:59:21 +00:00

fix: port standardization per hero_ports registry #3

mik-tf commented 2026-02-19 02:59:21 +00:00

Author

Owner

Copy link

Superseded by #3 — consolidated to development_mik branch with latest development merged in.

Superseded by #3 — consolidated to `development_mik` branch with latest `development` merged in.

mik-tf closed this pull request 2026-02-19 02:59:26 +00:00

All checks were successful

Hide all checks

Build and Test / build-and-test (pull_request) Successful in 7m7s

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_launcher!2

No description provided.